Problem/Motivation

We'd like to find out the greatest number of test fails/exceptions that can be caused by a single patch.

Rules:

  1. You can only delete code, no code can be added.
  2. You cannot touch t() or any code it delegates to.
  3. Your patch must pass installation and complete testing.

Proposed resolution

The only winning move is not to pass!

Remaining tasks

Leaders:

Most exceptions:
152,655 by @larowlan in #20

Most failures:
82,363 by @jibran in #62

Most green patches (not a good thing):
1 by @jibran in #32, @lauriii in #43

User interface changes

API changes

CommentFileSizeAuthor
#73 render-nothing.patch12.28 KBmpdonadio
#68 drupal_2418019_68.patch2.77 KBXano
#62 more-fail-v2.1.patch198.91 KBjibran
#60 more-fail-v3.patch197.94 KBjibran
#58 more-fail-v2.patch199.51 KBjibran
#56 more-fail.patch1.47 KBjibran
#53 please-fail.patch640 bytesjibran
#49 render-nothing-no-memory.patch12.01 KBmpdonadio
#47 render-nothing.patch11.54 KBmpdonadio
#45 get-crazy.patch495 byteslauriii
#43 stolen-idea.patch756 byteslauriii
#40 2418019-40.patch675 bytesdawehner
#38 2418019.patch5.27 KBmpdonadio
#36 2418019-36.patch712 bytesdawehner
#32 must-fail.patch458 bytesjibran
#30 2418019-html-renderer-fail.patch739 bytesDave Reid
#27 fail-all-4.patch1.41 KBjibran
#24 2418019-curious-if-fails.patch1.44 KBDave Reid
#22 2418019-ultra-mega-fail.patch1.2 KBDave Reid
#20 testbot-crazy.larowlan1.patch711 byteslarowlan
#18 2418019-18.patch1.4 KBdawehner
#13 2418019-mega-fail.patch1.75 KBDave Reid
#12 all-fail-3.patch1.1 KBjibran
#9 all-fail-2.patch376 bytesjibran
#7 all-fail.patch8.39 KBjibran
#3 2418019-1.patch893 bytesdawehner
#1 removed-19-characters.patch429 bytestim.plunkett
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Issue summary: View changes
Status: Active » Needs review
FileSize
removed-19-characters.patch429 bytes
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
FileSize
2418019-1.patch893 bytes
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs work » Needs review

.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Issue summary: View changes
jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Status: Needs work » Needs review
FileSize
all-fail.patch8.39 KB

Let's try this one.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Status: Needs work » Needs review
FileSize
all-fail-2.patch376 bytes
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

@jibran
Please stick to the rules.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
FileSize
2418019-mega-fail.patch1.75 KB
jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
FileSize
all-fail-3.patch1.1 KB

Ok

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
FileSize
2418019-mega-fail.patch1.75 KB

Uh, rude.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented 
+++ b/core/vendor/phpunit/phpunit/src/Framework/Constraint.php
@@ -51,10 +51,6 @@ public function evaluate($other, $description = '', $returnResult = false)
-        if ($this->matches($other)) {
-            $success = true;
-        }

I'd argue that this is not the part of Drupal :D

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

Doesn't say it's limited to Drupal code only in the rules. Only deletions.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Issue summary: View changes

Clarifying that it must complete testing.
No rules against changing vendor code, we should be using composer anyway, but that's for another issue.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs work » Needs review
FileSize
2418019-18.patch1.4 KB

@davereid
Really good try/

Here is another approach.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented

How about #2074297-14: Optimize the code in doGenerate() in the UrlGenerator to take advantage of Drupal path restrictions. although more than deletions there

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
FileSize
testbot-crazy.larowlan1.patch711 bytes
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
FileSize
2418019-ultra-mega-fail.patch1.2 KB

I'm going the non-exception route, I think that's an easy way.

Despite Git showing this as having a one-line addition, you can clearly see it was only done with deleting.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Needs work » Needs review
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
FileSize
2418019-curious-if-fails.patch1.44 KB
jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Status: Needs work » Needs review
FileSize
fail-all-4.patch1.41 KB
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented

152,655 exceptions - we have a new leader :)

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
FileSize
2418019-html-renderer-fail.patch739 bytes
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Needs work » Needs review
jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
FileSize
must-fail.patch458 bytes
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

Ok I think I still lead the "line deletions only" group.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented

And I have a green patch :D

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
FileSize
2418019-36.patch712 bytes

Let's try another one

mpdonadio’s picture

mpdonadio
he/him
Primary language English
Location Philadelphia/PA/USA (UTC-5)
CreditAttribution: mpdonadio commented
Status: Needs work » Needs review
FileSize
2418019.patch5.27 KB
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Issue summary: View changes
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
FileSize
2418019-40.patch675 bytes

Stealing an idea.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 40: 2418019-40.patch, failed testing.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii commented
Status: Needs work » Needs review
FileSize
stolen-idea.patch756 bytes

So what about this :P

EclipseGc’s picture

EclipseGc CreditAttribution: EclipseGc commented
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii commented
FileSize
get-crazy.patch495 bytes
davidhernandez’s picture

davidhernandez
Primary language English
Location USA
CreditAttribution: davidhernandez commented

LOL! The one time Lauri wantsfails they pass!

mpdonadio’s picture

mpdonadio
he/him
Primary language English
Location Philadelphia/PA/USA (UTC-5)
CreditAttribution: mpdonadio commented
FileSize
render-nothing.patch11.54 KB

Status: Needs review » Needs work

The last submitted patch, 47: render-nothing.patch, failed testing.

mpdonadio’s picture

mpdonadio
he/him
Primary language English
Location Philadelphia/PA/USA (UTC-5)
CreditAttribution: mpdonadio commented
Status: Needs work » Needs review
FileSize
render-nothing-no-memory.patch12.01 KB

Let's see how PHPUnit does with 1 byte of memory when TestBot runs it.

Status: Needs review » Needs work

The last submitted patch, 49: render-nothing-no-memory.patch, failed testing.

The last submitted patch, 45: get-crazy.patch, failed testing.

The last submitted patch, 18: 2418019-18.patch, failed testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
FileSize
please-fail.patch640 bytes
jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 53: please-fail.patch, failed testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Status: Needs work » Needs review
FileSize
more-fail.patch1.47 KB

Status: Needs review » Needs work

The last submitted patch, 56: more-fail.patch, failed testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Status: Needs work » Needs review
FileSize
more-fail-v2.patch199.51 KB

Cuz I can.

Status: Needs review » Needs work

The last submitted patch, 58: more-fail-v2.patch, failed testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Status: Needs work » Needs review
FileSize
more-fail-v3.patch197.94 KB

Hmmm

Status: Needs review » Needs work

The last submitted patch, 60: more-fail-v3.patch, failed testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Status: Needs work » Needs review
FileSize
more-fail-v2.1.patch198.91 KB

git--

Status: Needs review » Needs work

The last submitted patch, 62: more-fail-v2.1.patch, failed testing.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented
Issue summary: View changes

Most failures:
82,363 by @jibran in #62

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented 
+++ b/core/modules/simpletest/src/TestBase.php
@@ -368,9 +368,7 @@ protected function checkRequirements() {
-    if (is_bool($status)) {
-      $status = $status ? 'pass' : 'fail';
-    }
+      $status = 'fail';

Patch in #62 fails the rules...

You can only delete code, no code can be added.
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented

Hmmm thinking about it I'm wrong that diff can be achieved with only the delete key :)

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano at My name is Bart commented
Status: Needs work » Needs review
FileSize
drupal_2418019_68.patch2.77 KB

Status: Needs review » Needs work

The last submitted patch, 68: drupal_2418019_68.patch, failed testing.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano at My name is Bart commented

Awwww :P

EclipseGc’s picture

EclipseGc CreditAttribution: EclipseGc at Acquia commented

LOL, wow yeah Ok jibran won the game. It follows the letter of the law but not its spirit. So we acknowledge the win, and now we outlaw it. No screwing with test statuses, also likely a good rule that you can't mess with tests at all. You have to affect the functional code that represents Drupal's actual operation, not the code that tests that operation.

:-D

Eclipse

EclipseGc’s picture

EclipseGc CreditAttribution: EclipseGc at Acquia commented
Issue summary: View changes
mpdonadio’s picture

mpdonadio
he/him
Primary language English
Location Philadelphia/PA/USA (UTC-5)
CreditAttribution: mpdonadio commented
FileSize
render-nothing.patch12.28 KB

OK, I resubmit #47 under the new rules.

mpdonadio’s picture

mpdonadio
he/him
Primary language English
Location Philadelphia/PA/USA (UTC-5)
CreditAttribution: mpdonadio commented
Status: Needs work » Needs review
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

I call BS on changing the rules.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett at Acquia commented
Issue summary: View changes

@EclipseGc cannot change the rules. The rules stand as they were when @dawehner and I came up with them.

Status: Needs review » Needs work

The last submitted patch, 73: render-nothing.patch, failed testing.

EclipseGc’s picture

EclipseGc CreditAttribution: EclipseGc at Acquia commented

You have to change the rules, Jibran already "won". He achieved failure on EVERYTHING, so the game is broken without the change. if you don't change the rules, there's no point.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

Well, its also about the elegance of the solution if you ask me :)

Meh, if I just would remember the test failure I had recently with > 200k in one test.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Status: Needs work » Closed (works as designed)

This looks like a fun little challenge.

It has been 8 years with no activity, I guess that has served it's purpose.