Problem/Motivation

After adding a custom block you can find the custom block in the list of admin/structure/block, but you are not provided with a link to edit this block.

To actually edit the block you have to switch to the "Custom block library" admin/structure/block/block-content, to find the contextual "Edit" link you are looking for.

This is very puzzeling, especially if you manage to create your new block on admin/structure/block by clicking "Place block" near a region header and follow "Add custom block" in the dialog. This way you are able to create a block without ever visiting the "Custom block library".

Proposed resolution

Add an "Edit" link for custom blocks in admin/structure/block.

Remaining tasks

- Add contextual links
- Write/adapt tests

User interface changes

- Custom block have an extra link in the list of admin/structure/block.

Original issue summary

Referring to http://drupal.stackexchange.com/questions/144133/contextual-links-for-cu...

"I have created a custom block type and it would be wonderful to have a link in the block dropbutton: "Edit block content"."

thanks and regards
sb

CommentFileSizeAuthor
#36 add-edit-link-in-layout-builder-2407761-36.patch1.58 KBluis_oliveira
#30 add-edit-link-in-layout-builder-2407761-30.patch1.43 KBmaithili11
#26 block_content_edit_link_in_layout_builder_202001090930.patch1.53 KBOscaner
#25 add-edit-link-in-layout-builder-2407761-25.patch838 bytesno74h
#24 edit_link.png174.83 KBOscaner
#23 add_edit_link_in_layout_builder_201911081741.patch1.42 KBOscaner
#21 add_edit_link_to_block_list-2407761-21.patch3.09 KBandriyun
#5 add_edit_link_to_block_list-2407761-5.patch2.95 KBg.oechsler
#3 custom_block_contextual_links.png42.23 KBg.oechsler

Comments

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Version: 8.0.0-beta4 » 8.0.x-dev
grendzy’s picture

grendzy commented
Status: Active » Closed (duplicate)

I believe this has been fixed: #2284917: In-place editing of custom blocks broken *again* (because attributes and contextual links of custom blocks are lost)

g.oechsler’s picture

g.oechsler commented
Issue summary: View changes
Status: Closed (duplicate) » Needs work
StatusFileSize
new custom_block_contextual_links.png42.23 KB

This is not a duplicate of #2284917: In-place editing of custom blocks broken *again* (because attributes and contextual links of custom blocks are lost).

This is about the contextual links on admin/structure/block.

I updated the summary to point out the issue.

g.oechsler’s picture

g.oechsler commented
Issue tags: +Usability
g.oechsler’s picture

g.oechsler commented
Status: Needs work » Needs review
StatusFileSize
new add_edit_link_to_block_list-2407761-5.patch2.95 KB

Here's a first shot at this.
Let's see what the testbot thinks of it.

lewisnyman’s picture

lewisnyman
he/him
commented
Issue tags: +Needs usability review
lewisnyman’s picture

lewisnyman
he/him
commented
Title: Contextual links for custom blocks: Add “Edit block content” » Add a way to edit block content on the block layout page
Component: contextual.module » block.module
Category: Feature request » Task
Issue summary: View changes
olli’s picture

olli commented

This sounds like #2331603: Where to edit the contents of a custom block is not discoverable.

MattA’s picture

MattA commented
Related issues: +#1956134: Provide helpful editing links on "admin/structure/block" for deriver blocks (menu, views, block content, etc.), +#2331603: Where to edit the contents of a custom block is not discoverable

I don't really think hard-coding support for only the block_content.module in block.module is the way to go. Looks like #1956134: Provide helpful editing links on "admin/structure/block" for deriver blocks (menu, views, block content, etc.) had a generic implementation that would have supported menus and views too, but OperationsProviderInterface is no longer used anywhere in core, so that won't work anymore.

Bojhan’s picture

Bojhan commented
Issue tags: -Needs usability review +Needs screenshots

This needs a screenshot.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Version: 8.0.x-dev » 8.1.x-dev
Status: Needs review » Postponed

@LewisNyman Can you elaborate why you moved this to a task? Still reads like a feature request to me.
Either way, not a bug fix.

lewisnyman’s picture

lewisnyman
he/him
commented
Category: Task » Feature request

@tim.plunkett hmm good question. I can't remember and it doesn't seem clear to me looking at the issue summary. Let's change it back in that case.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

murz’s picture

murz
Primary language English
Location Yerevan, Armenia
commented

Same UI problem with editing block content also have Layout Builder edit page. Custom blocks can be edited only via small right sidebar, that have very little width. Will be good to have also contextual link to full block edit page.

andriyun’s picture

andriyun commented
StatusFileSize
new add_edit_link_to_block_list-2407761-21.patch3.09 KB

Rerolled patch #5

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Oscaner’s picture

Oscaner commented
StatusFileSize
new add_edit_link_in_layout_builder_201911081741.patch1.42 KB

I add an "Edit" contextual link for content block in layout screen, this can redirect to the block edit screen.

edit_link.png

Oscaner’s picture

Oscaner commented
StatusFileSize
new edit_link.png174.83 KB
no74h’s picture

no74h
Him
Primary language English
Location Orbit
commented
StatusFileSize
new add-edit-link-in-layout-builder-2407761-25.patch838 bytes

Hi, I edited patch in #23 to also support core (edit, translate..) contextual links in layout edit page for block content types and their translations.

Oscaner’s picture

Oscaner commented
StatusFileSize
new block_content_edit_link_in_layout_builder_202001090930.patch1.53 KB

Change the #23 patch to only block_content block, no inline_block.

no74h’s picture

no74h
Him
Primary language English
Location Orbit
commented
Related issues: +#3106035: Providing module-defined contextual links for blocks in layout builder edit page

I opened a related issue for fixing comment #20 demand. https://www.drupal.org/project/drupal/issues/3106035

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

maithili11’s picture

maithili11 commented
StatusFileSize
new add-edit-link-in-layout-builder-2407761-30.patch1.43 KB

Some changes in the #23 patch to work with 8.9.9.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

#1956134: Provide helpful editing links on "admin/structure/block" for deriver blocks (menu, views, block content, etc.) looks like a (better as more general) duplicate to this issue. Keeping this postponed, but after that issue was fixed, we should check to close this as duplicate.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Postponed » Closed (duplicate)

So this functionality is being applied to https://www.drupal.org/project/drupal/issues/1956134. So I'm closing as a duplicate and will leave a comment in https://www.drupal.org/project/drupal/issues/1956134 for credit to be moved over.

If anyone feels this is a separate issue please reopen with explanation of difference.

Thanks.

luis_oliveira’s picture

luis_oliveira commented
StatusFileSize
new add-edit-link-in-layout-builder-2407761-36.patch1.58 KB

I used patch #30 but did not work, I did some debugging and found out that in Drupal 10 the array key 0 does not exist so the if statement would be skipped.

<?php
if (isset($build[$region][$uuid]['content'][0]['#block_content'])) {
?>

I fixed that and added the "edit" option in the operation metadata.

luis_oliveira’s picture

luis_oliveira commented
Version: 9.5.x-dev » 10.2.x-dev