This code throws notices.

Notice: Undefined variable: list in ctools_context_user_convert_list() (line 160 of .. sites/all/modules/contrib/ctools/plugins/contexts/user.inc).

Looks like $list should be initialized as an empty array first.

CommentFileSizeAuthor
#1 ctools-notice_undefined_variable_list-2402045-1.patch865 bytesothermachines
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

othermachines’s picture

othermachines CreditAttribution: othermachines commented
Version: 7.x-1.5 » 7.x-1.x-dev
Status: Active » Needs review
FileSize
ctools-notice_undefined_variable_list-2402045-1.patch865 bytes
Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews as a volunteer commented

The patch to user.inc applied cleanly to the latest ctools 7.x-1.x-dev, and if still applicable needs to be reviewed and tested by the community.

Checking patch plugins/contexts/user.inc...
Hunk #1 succeeded at 152 (offset 1 line).
Applied patch plugins/contexts/user.inc cleanly.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet at The University of British Columbia commented
Status: Needs review » Fixed

Thanks @othermachines and @Chris2. That is pretty straight forward and I've committed it to the -dev branch.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet at The University of British Columbia commented
Parent issue: » #2984057: Plan for CTools 7.x-1.15 release

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.