Refactor "Edit block" and add "Edit menu links" items in pane dropdown links

I'm guessing this code would go in:

panels/plugins/display_renderers/panels_renderer_editor.class.php:

to be included in function get_pane_links or should it just be on it's own like:

/**
 * Implements hook_get_pane_links_alter().
 */
function panels_get_pane_links_alter(&$links, $pane, $content_type) {
// add an Edit view link for views block displays
if ($pane->type === 'views') {
  $path = explode('-', $pane->subtype);
  $view_name = $path[0];
  $display_name = $pane->configuration['display'];

  $destination = array('destination' => current_path());
  $links['top'][] = array(
    'title' => t('Edit view'),
    'href' => url('admin/structure/views/view/' . $view_name . '/edit/' . $display_name, array('query' => $destination, 'absolute' => TRUE)),
  );
}

// add a Edit block link for custom blocks or views blocks
if ($pane->type === "block"){
  $name_of_block = "";
  $prefixed_name = $pane->subtype;

  // breakup the subtype string
  $exploded_subtype = explode('-', $pane->subtype);

  // contains view- or block-
  $subtype_prefix = $exploded_subtype[0] . '-';

  // remove the prefix to get the name
  $name_of_block = ltrim( $prefixed_name, $subtype_prefix);

  $links['top']['edit_custom_content'] = array(
    'title' => t('Edit block'),
    'href' => url('admin/structure/block/manage/' . $name_of_block . '/edit', array('absolute' => TRUE)),
    'attributes' => array('target' => array('_blank')),
  );
}

Thanks @merlinofchaos! Here's a patch. Hope that helps

Panels 3.x-dev already has support for edit links for Mini Panels and custom content panes. Now we just need to finish it and add edit links for blocks(this issue) and views #1948278: Get an edit link for the view panes in Page Manger.

Oops.. I didn't see the comment about the Deprecated functions. Better add my stuff above that line. Here is a new patch.

@DamienMcKenna - Well, I wasn't quite sure of where the code for views blocks should go? Maybe it should go directly in the views.module file? The patch in #1948278: Get an edit link for the view panes in Page Manger for views panes goes in the views_content module.

I'll try to update both patches (here and the views modules)

Ok, I split out the code into another issue for views. #2387193: Get an edit link for the views blocks in Page Manger

Here is a new patch for this issue.

@japerry - yes I think your right. Here is an untested updated patch with the change.

Noticed it has 'edit_custom_content' and it instead needs to be 'edit_block'. I'm also going to try to include an edit link for menu blocks as well.

Here is a patch that adds "Edit block", "Edit menu links", and "Edit: fieldname" links. I took and had to modify the code from @bobodrone PAL module https://www.drupal.org/sandbox/bobodrone/1497388

Hope that helps

The patch in #11 adds Edit field links support, but it uses a sql query per field and I'm not sure how it works when a field is shared between two content types. It does this because you have to know the field's bundle to edit the field.

After more testing, I can't find a way to reliably get Field edit links because they require the field instance's bundle name in the link.

So were back to just Blocks and Menu links. Here is a new patch. Hope that helps

Here is a reroll to accommodate the latest changes in dev.

Hi Michelle. Yes your right, this is confusing. After more research, this was more complex than I thought.

I just tested using the lastest Panels 3.x-dev and Ctools 1.x-dev.
-- I added a pane Menu>Development. All it provided was "Edit block".
-- Menu block content panes don't have a "Edit block" or "Edit menu links."
-- I added a pane Widgets>User Login. It provides a "Edit block" link, but clicking it causes a fatal error.
-- I added a pane Widgets>Powered By Drupal. It provides a "Edit block" link, but clicking it causes a fatal error.
-- I added a pane Menus>Development (which is provided by Devel module). It provides a "Edit block" link, but clicking it causes a fatal error.

I'll try to add submit a patch that covers the following:
1...User added menus at /admin/structure/menu/add
2...system blocks with menu links - Like "Navigation"
3...For the Menu Block module's menus, see #2400145: add "Edit menu links" to the Panels pane links dropdown menu.
4...module provided menu blocks like Devels or Features
5...fixes fatal errors on some "Edit block" links and provides "Edit menu links"

Just so we are clear, here is a screenshot of what I'm talking about.

Hope that helps

Updating issue summary.

Hi @Michelle, setting this back to NR. See the patch in #17. I shouldn't have said I'll try, because I did provide a patch. :)