WIth the patch in #1400884: Custom menu items in pane dropdown links, an hook_alter is added to panels pane links menu, and it should be great to have an edit link from the panes from Views to the edit of the View - see attached image. Patch will follow.

Edit view pane

CommentFileSizeAuthor
#16 edit_views_pane-1948278-16.patch866 bytesmisc
#12 edit_views_pane-1948278-12.patch783 bytesmaximpodorov
#1 edit_views_pane-1948278-1.patch939 bytesmisc
edit_view_pane.png7.28 KBmisc

Comments

misc’s picture

misc commented
StatusFileSize
new edit_views_pane-1948278-1.patch939 bytes

Suggested patch.

gmclelland’s picture

gmclelland commented

@MiSc - This looks like it would be a helpful improvement, but after testing I couldn't see any difference. I didn't see the "Edit View" link.

misc’s picture

misc commented

Did you test it with the patch in #1400884: Custom menu items in pane dropdown links?

misc’s picture

misc commented
Status: Active » Needs review
gmclelland’s picture

gmclelland commented

Oh sorry, I read through this issue to fast. I will try and report back.

gmclelland’s picture

gmclelland commented

Works as advertised with the patch in #6 #1400884-6: Custom menu items in pane dropdown links

misc’s picture

misc commented
Status: Needs review » Reviewed & tested by the community

Mark as RTBC as for comment #6.

japerry’s picture

japerry
Location KOMK
commented
Issue summary: View changes
Status: Reviewed & tested by the community » Closed (duplicate)
Parent issue: » #1400884: Custom menu items in pane dropdown links
Related issues: +#2108413: Add edit link for custom content panes

Marking as duplicate of the newer issue #2108413: Add edit link for custom content panes

gmclelland’s picture

gmclelland commented
Status: Closed (duplicate) » Reviewed & tested by the community

@japerry - Thanks, but this is not duplicate.

The patch in #1400884-6: Custom menu items in pane dropdown links provides a way to add custom contextual links to panes including links to edit Mini Panels. This is already committed in Panels 3.x-dev.

The patch in #2108413: Add edit link for custom content panes provides edit links for custom content panes. - I didn't see where this is committed to Ctools?

The patch in this issue #1948278-1: Get an edit link for the view panes in Page Manger provides edit links for views panes. -This still needs to be committed to Ctools.

Hope that helps clarify everything.

gmclelland’s picture

gmclelland commented

1: edit_views_pane-1948278-1.patch queued for re-testing.

smussbach’s picture

smussbach commented

I can confirm that this patch works as expected with panels patch #1400884-6: Custom menu items in pane dropdown links as advised in comment #3. Really sweet! Looking forward to this.

maximpodorov’s picture

maximpodorov commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new edit_views_pane-1948278-12.patch783 bytes

I simplified the patch. Please do not force the end user to open links in the new window.

gmclelland’s picture

gmclelland commented

@maximpodorov - Haven't tested yet, but thanks for the patch. If you don't think we should open the links in a new window, then we also need to add a patch to update this issue #2108413: Add edit link for custom content panes as well.

misc’s picture

misc commented

If the link should not be opened in a new window, I think we need destination in url, it would make more sense.

maximpodorov’s picture

maximpodorov commented

It makes sense.

misc’s picture

misc commented
StatusFileSize
new edit_views_pane-1948278-16.patch866 bytes

Added new patch with destination in url to get back after editing the view.

maximpodorov’s picture

maximpodorov commented
Status: Needs review » Reviewed & tested by the community

Works great. Please commit.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Related issues: +#1669756: Provide a contextual link for view panes
gmclelland’s picture

gmclelland commented

Just tested against the latest devs of ctools and panels and the patch in #16 works as advertised.

gmclelland’s picture

gmclelland commented

Also see #2381319: Refactor "Edit block" and add "Edit menu links" items in pane dropdown links. I added a patch to add "Edit block" links.

gmclelland’s picture

gmclelland commented

For views blocks edit links, see #2387193: Get an edit link for the views blocks in Page Manger.

  • japerry committed ffe5a37 on 7.x-1.x authored by MiSc 
    Issue #1948278 by MiSc, maximpodorov, gmclelland: Get an edit link for...
japerry’s picture

japerry
Location KOMK
commented
Status: Reviewed & tested by the community » Fixed

Looks good, committed!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.