Problem/Motivation

This is a follow-up on this comment: https://www.drupal.org/node/2364555#comment-9336771

SqlContentEntityStorageSchema::performFieldSchemaOperation() has no unit test coverage, though its wrapper method does: onFieldStorageDefinitionCreate().

There should be wider unit coverage of performFieldSchemaOperation(), since it's the main dependency of a number of wrapper methods for various combination of operations and underlying table mappings.

Proposed resolution

Write a thorough unit test of performFieldSchemaOperation().

Remaining tasks

Review the patch.
Commit the patch.
Rejoice.

User interface changes

API changes

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Unfrozen changes Unfrozen because it only improves automated tests.
Files: 
CommentFileSizeAuthor
#3 2377715_3.patch4.59 KBMile23
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 90,587 pass(es).
[ View ]
#1 2377715_1.patch4.5 KBMile23
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 81,232 pass(es).
[ View ]

Comments

Mile23’s picture

Status:Active» Needs review
StatusFileSize
new4.5 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 81,232 pass(es).
[ View ]

The patch.

Mocks all dependencies, follows all code paths.

Mile23’s picture

Mile23’s picture

StatusFileSize
new4.59 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 90,587 pass(es).
[ View ]

Needed a reroll.

Added some comments.