Problem/Motivation

The quiz_update_max_score_properties() function changes quiz's max_score properties directly using raw SQL queries. This make contributed module can not have easy way to know when the max_score is changed.

Proposed resolution

- Add new function: quiz_update_single_max_score_property($quiz)
- Use new function in quiz_update_max_score_properties()

Make use of entity API here, we can remove usage of COALESCE function, which is only available in MySQL 5.6.

CommentFileSizeAuthor
#5 contributed_module_can-2374317-5.patch2.85 KBdjdevin
#2 contributed_module_can-2374317-2.patch2.74 KBdjdevin
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

djdevin’s picture

djdevin
Location Philadelphia
CreditAttribution: djdevin commented
Issue tags: +7.x-5.0 release blocker
djdevin’s picture

djdevin
Location Philadelphia
CreditAttribution: djdevin at Cadmium commented
Status: Active » Needs review
FileSize
contributed_module_can-2374317-2.patch2.74 KB

Status: Needs review » Needs work

The last submitted patch, 2: contributed_module_can-2374317-2.patch, failed testing.

The last submitted patch, 2: contributed_module_can-2374317-2.patch, failed testing.

djdevin’s picture

djdevin
Location Philadelphia
CreditAttribution: djdevin at Cadmium commented
Status: Needs work » Needs review
FileSize
contributed_module_can-2374317-5.patch2.85 KB
djdevin’s picture

djdevin
Location Philadelphia
CreditAttribution: djdevin at Cadmium commented
Status: Needs review » Fixed

  • djdevin committed 8c5b25f on 7.x-5.x 
    Issue #2374317 by djdevin: Contributed module can not know when quiz....
djdevin’s picture

djdevin
Location Philadelphia
CreditAttribution: djdevin at Cadmium commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.