Problem/Motivation

I would like to refactor the UserData class cos currently the get method looks like something the cat dragged in. Compare to the tidy MongoDB version which can be applied to the SQL version as well just the query is different, the result rows are not. But there are no tests. Woe.

Proposed resolution

Add tests.

Remaining tasks

Add tests.

User interface changes

API changes

Files: 
CommentFileSizeAuthor
#1 2373573-user-data-test-1.patch2.8 KBvijaycs85

Comments

vijaycs85’s picture

chx’s picture

Assigned: Unassigned » chx

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

kiamlaluno’s picture

Version: 8.3.x-dev » 8.4.x-dev
Status: Active » Needs work
+/**
+ * @file
+ * Contains \Drupal\user\Tests\UserDataTest.
+ */

@file is not required anymore for those files.

+/**
+ * Tests the user entity class.
+ *
+ * @group user
+ * @see \Drupal\user\UserData
+ */
+class UserDataTest extends UnitTestCase {

It is testing the user.data service, not the user entity class.