[D7]Views_Reveal

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2372249

Project 2: https://www.drupal.org/node/2325531

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxadam_bear2369977git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2372249

Project 2: https://www.drupal.org/node/2325531

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

1)An unwanted space need to be deleted in line no 213 of views_reveal.module
2)Project page needs updation. Your project page should inform users about the features to your module.
3)The function views_reveal_js_alter() in line no 151 of views_reveal.module is commented. If its not required delete the same.

changed the status to 'Needs work'

@adam_bear,

No description on your project applicantion ? No link to the sandbox ? These things have to be provide by the developer. Do not worry I fix it for you. Once again you should consider reviewing other project otherwiser your project application is going to take more time.

Automated Review

You have a lot errors and warning detect from the automate test. Can you please fix them ? A great tool that would fix most of them for you is the coder module. Check this article is going to tell you how to auto-fomart your code using drush + coder. https://www.drupal.org/node/2148421

Here is the automatice test - http://pareview.sh/pareview/httpgitdrupalorgsandboxadambear2369977git

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.]

Coding style & Drupal API usage

[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:

1. You should consider adding a different name to your css and javascript. It might be confusing for because there is a module that called draggableviews. You should called something like this views_reveal_list.css instead of draggableviews_list_reveal.css
2. Two README ? I know that you have both of them one for Github and the another one for Drupal. But you should have one read me instead with the all the information instead of having two with different info.
3. Hook_help have a link that goes no where. You should delete or correct the link.
4. Project Name on your sandbox change it to Views Reveal instead of Views_Reveal
5. Draggable Views is a dependecy, if so you need to add them to your info file.
6. Ideally, your module is not going to install unless there is the library. You should force user to install the reveal.js library before of install the module. If they try to installed provide them an error saying you need to install the library.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

I think this is a great start for you to be improving your module.

1) Correct your readme file name.
It should be README.md instead of readme.md

2) There are lots of coder errors in your project. Install coder module, check your module with coder and fix those errors.

Hi adam_bear,
1. Its not good to instruct your user to keep the library in sites/all only. Its the preferred place, ofcourse, but they may choose a different place.
2. You have made a heavy usage of drupal_get_path('module', 'views_reveal');
So, instead save it in a constance and use it at every place.
define('VIEWS_REVEAL_MODULE_PATH', drupal_get_path('module', 'views_reveal'));
3. You have both views_reveal.js and views_reveal.min.js in your project. No need of both. Remove any one.
4. I do not think there is any use of *.install file in your module. Instead, keep the check in the function views_reveal_assets(&$view) itself where you are assigning the value to $lib.

Correct these and commit again. Once done, set back the status to "Needs Review". Would be happy to review your module again.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.