[D7] Outdated Browser

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Errors in the code not found.

Tested in ie8, ie9, opera 12.0 there were no reports that the browser is outdated.

I like the start on feature detection (I'd love to be able to add a few different requirements there), which seems different enough from the other browser detectors I'm aware of.

I also didn't see any code problems, no license issues, and the documentation looks good.

It went through Coder with no warnings.

But like oss-usa.com, I'm also not getting a message to update when I switch my (Chrome) user agent to Mozilla/5.0 (compatible; MSIE 8.0; Windows NT 6.1; Trident/4.0; GTB7.4; InfoPath.2; SV1; .NET CLR 3.3.69573; WOW64; en-US), with the setting at either "8" or "transform". The status page shows that I have version 1.1.0 of the outdatedbrowser library available.

That is the only thing that I'd say should be resolved for sure before I'd move forward.

Two other (non-blocking) suggestions:
1. The library has a hyphen in the parent folder name. I missed that for a while, so I'd either emphasize it in the documentation or change it in the code.
2. Some sort of test for the library/reminder to add it could be helpful.

This module will be very helpful! Thank you for contributing!

Hi agoradesign,
hook_help() is not available in your module.

Thanks,
Rahul.

Git clone command for the sandbox is missing in the issue summary, please add it.

I'm a robot and this is an automated message from Project Applications Scraper.

Thanks for adding a hook_help().

1) i have downloaded a outdated-browser-develop.zip from https://github.com/burocratik/outdated-browser/archive/develop.zip and place a outdatedbrowser.js file in /sites/all/libraries/outdatedbrowser/outdatedbrowser/outdatedbrowser.js

2) jquery update module is set at 1.7.

3) current using browser Chromium Version 37.0.2062.94 Ubuntu 14.04 (290621) still i am getting error on in console
Uncaught ReferenceError: outdatedBrowser is not defined outdatedbrowser.js:9
Failed to load resource: net::ERR_FAILED chrome-extension://boadgeojelhgndaghljhdicfkmllpafd/cast_sender.js
Failed to load resource: net::ERR_FAILED chrome-extension://dliochdbjfkdbacpmhlcpmleaejidimm/cast_sender.js
Failed to load resource: net::ERR_FAILED chrome-extension://hfaagokkkhdbgiakmmlclaapfelnkoah/cast_sender.js
Failed to load resource: net::ERR_FAILED chrome-extension://fmfcbgogabcbclcofgocippekhfcmgfj/cast_sender.js
Failed to load resource: net::ERR_FAILED chrome-extension://enhhojjnijigcajfphajepfemndkmdlo/cast_sender.js
4) also,tried on Mozilla firefox for ubuntu canonical - 1.0 still get error
ReferenceError: outdatedBrowser is not defined
outdate...?nhokzg (line 9, col 4)
Use of getPreventDefault() is deprecated. Use defaultPrevented instead.
jquery-....min.js (line 3)

Please correct me if i am doing anything wrong.
Thanks,
Rahul.

1. outdatedbrowser_page_build(&$page): you should'nt use drupal_add_js() here, use #attached with the $page render array that this function should receive. See https://api.drupal.org/api/drupal/developer!topics!forms_api_reference.h...
2. outdatedbrowser_requirements : you need to check if libraries is installed and libraries_detect exist before calling it.
   <?php if (module_exists('libraries') && function_exists('libraries_detect')) { }?>
3. I've installed the module without the outdated library and it break all javascript of my Drupal site. If the library is not installed, your module should'nt call it. See screenshot

I've set a "Need work" status until #15 bugs will be fixed.

Thanks, looks good - RTBC

manual review:

• outdatedbrowser_help(): filter_xss_admin() and check_plain() are wrong here, since no user provided text is involved. The contents of README.txt are provided by you, the developer, so you can trust what is in there. Make sure to read https://www.drupal.org/node/28984 again. Looks like this now fixed on the doc page, too: https://www.drupal.org/node/161085

But otherwise looks good to me, so ...

Thanks for your contribution, agoradesign!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.