Some contrib entities has no support for UUID, let's skip them. [#2356305]

There are some contrib entities without uuid support that leads to SQL errors

 SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near &#039;AS #012FROM #012crm_core_contact t#012WHERE  (contact_id IN  (&#039;2816&#039;))&#039; at line 1: SELECT t.contact_id AS contact_id, t. AS #012FROM #012{crm_core_contact} t#012WHERE  (contact_id IN  (:db_condition_placeholder_0)) ; Array#012(#012    [:db_condition_placeholder_0] =&gt; 2816#012)#012 in entity_get_uuid_by_id() (line 476 of /var/www/sj-lou/sites/all/modules/contrib/uuid/uuid.entity.inc).

also this fix an error during uuid_update_7103

[error]
SQL syntax; check the manual that corresponds to your MySQL server version for the
right syntax to use near 'AS , t.nid AS nid
FROM 
node t
WHERE  ( IN  ('b0558664-c94b-3674-d9df-3e1696b2e4' at line 1
Performed update: uuid_update_7103

I have attached a patch for ability to skip them during conversion from references to uuid

Comment	File	Size	Author
#5	2356305-5.patch	891 bytes	dixon_
#5
#2	2356305-2.patch	905 bytes	dixon_
#2
	skip_unsupported_entities.patch	502 bytes	podarok

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

podarok

🇺🇦 he/him/his

Ukrainian

Ukraine

CreditAttribution: podarok commented 15 October 2014 at 11:18

Issue summary:

View changes

Comment #2

dixon_

he/him

English

France

CreditAttribution: dixon_ commented 15 October 2014 at 14:58

File	Size
2356305-2.patch	905 bytes

+++ b/uuid.entity.inc
@@ -468,6 +468,11 @@ function entity_get_uuid_by_id($entity_type, $ids, $revision = FALSE) {
+  // Some contrib entities has no support for UUID, let's skip them.
+  // This means reference will be lost during conversion.
+  if ($uuid_key == NULL) {
+    return array();
+  }

Everywhere else in the UUID module we do the checks on $info['uuid'] so I think that would be better and more consistent.

I've also added the same check in entity_get_id_by_uuid().

@podarok If all tests still pass, and you think this looks good then I'll commit this soon.