UUID export and import of menu items linking to nodes, terms and users

Thanks! I tried the patch and it succesfully imported menu links as part of my distribution profile.
What is odd though is that imported menu links do not get added during profile installation. It might be relevant that the menu links and the content that is linked are in the same feature module, so maybe the menu link features fails initially because the content is not added yet, or maybe a cache clear is needed after the content is added, before the links are added.

Using a little hack in my feature module's install file the import of menu links is completed after profile installation:

module_load_include('module', 'features');
features_revert(array('sooperthemes_glazed_config' => array('menu_links')));

major issue: after adding menu links to a feature the frontend menu actually links to a uuid path instead of a pathauto path. this is not good for SEO and not an option for existing sites.

update: I see I didnt have this problem on the site to which I exported the feature and the difference I noticed was the feature being enabled on the latter and disabled on the former site. When I enable the feature on the source site the menu links turn back to normal

I've rebuilt my menu and been spending all day trying to make it work but this is what happens:
1. Menu is fine
2. I add menu links to a feature and export it
3. The menu_links table gets updated, replacing my node links with uuid links, setting router path from node/% to uuid and setting the link_path to uuid too, making my menu turn into a uuid mess on the frontend.

update: I just noticed that if I revert the feature with the (bodged) menu links, the menu is back to normal. I have to delete a menu item before reverting otherwise it will show "default" status. I'm hoping it will stay working now but I still recommend anyone using this code to backup your database (often) when playing around.

Hi, I used the patch in comment #5, I'll post back when I will work on my menu links feature again and see if I can figure out if reverting fixes the problem

I am now applying #5 for DruStack http://cgit.drupalcode.org/drustack/commit/?id=b722665
Will report if error happened ;-)

I worked off of #5 to allow UUIDs to always stay in the info file instead of reverting back to node IDs.

Added another missing section where a link was loaded but uuid path not added for parent_identifier.

Found another issue where the uuid link was saved instead of the internal link so links were not displaying correctly.

Thanks for the patch. It worked for me. I was able to export nodes and menu items and import them back in another site with different node ids.

Revoke from #18 + code cleanup with coder + patch via latest 7.x-2.x

great work hswong3i.
I still have the prolbem of UUID Redirector showing on pages as a breadcrumb component. This is in nodes where the menu tree is used to generate breadcrumbs.
Any way to fix that?

Shouldn't this be a part of the UUID features module? It seems odd to include it here.

Don't include non-relevant code formats in your patch. It adds bulk to the patch and makes it harder to review.

Also, my suggestion is to re-roll this patch into UUID Features. There is no other UUID-related code in this module and I doubt they will want to add it since there is already a module that handles that functionality anyway.

Thank you everybody, this patch has been very useful for me, but now I have the same problem than #22.
JurriaanRoelofs, have you found any solution for the breadcrumb issue?

Just simply reroll #21 via latest 7.x-2.x changes.

(Well, sorry that I will not put else improvement effort for D7, just some simple maintenance duty)

I pushed a commit today that conflicts with patch 28.

Here's the reroll.

patch 28 is good for the release features 7.x-2.11

patch 29 works for the latest dev branch 7.x-dev

fixing regression in patch 29,
here's patch 30

I pushed a commit to the 7.x-2.x branch today that conflicts with patch 28.

Here's the reroll.

patch 28 is good for the release features 7.x-2.11

patch 30 works for the latest dev branch 7.x-dev

fixed in 7.x-2.x dev

For any related regressions such as the breadcrumb issue, please open a new issue and put a link to it here.

It is likely that some of these issues noted above have been fixed by other issues.

In any case, open a new issue and link it here as mentioned.

@joseph.olstad thank you very much ~~~

P.S. I just guess this issue may forever as a patch living inside my composer.json since #13 ;-P

@joseph.olstad The committed patch introduced some nasty code duplication into the code base (4x functionally equivalent code) and should be refactored into a helper function. Should I attach a follow-up patch to this issue or create a new one?

Duplicate code:

1. +++ b/includes/features.menu.inc
   @@ -210,7 +229,68 @@ function menu_links_features_export($data, &$export, $module_name = '') {
   +        $uri = explode('/', $link['link_path']);
   +        if (count($uri) == 3 && $uri[0] == 'uuid') {
   +          $entity_data = uuid_uri_array_to_data($uri);
   +          $entities = entity_uuid_load($entity_data['entity_type'], array($entity_data['uuid']));
   +          if (!empty($entities)) {
   +            $entity_type = $entity_data['entity_type'];
   +            $entity = reset($entities);
   +            $internal_uri = entity_uri($entity_data['entity_type'], $entity);
   +            $link['link_path'] = $internal_uri['path'];
   +          }
   +        }
   

2. +++ b/includes/features.menu.inc
   @@ -237,20 +327,34 @@ function menu_links_features_export_render($module, $data, $export = NULL) {
   +            $uri = explode('/', $temp['link_path']);
   +            if ($uri[0] == 'uuid' && count($uri) == 3) {
   +              $entity_data = uuid_uri_array_to_data($uri);
   +              $entities = entity_uuid_load($entity_data['entity_type'], array($entity_data['uuid']));
   +              if (!empty($entities)) {
   +                $entity = reset($entities);
   +                $internal_uri = entity_uri($entity_data['entity_type'], $entity);
   +                $temp['link_path'] = $internal_uri['path'];
   +              }
   +            }
   

3. +++ b/includes/features.menu.inc
   @@ -328,6 +432,23 @@ function menu_links_features_rebuild_ordered($menu_links, $reset = FALSE) {
   +      $internal_path = '';
   +      $uri = explode('/', $link['link_path']);
   +      if (module_exists('uuid') && $uri[0] == 'uuid' && count($uri) == 3) {
   +        $entity_data = uuid_uri_array_to_data($uri);
   +        $entities = entity_uuid_load($entity_data['entity_type'], array($entity_data['uuid']));
   +        if (!empty($entities)) {
   +          $entity = reset($entities);
   +          $internal_uri = entity_uri($entity_data['entity_type'], $entity);
   +          $internal_path = $internal_uri['path'];
   +        }
   +      }
   

4. +++ b/includes/features.menu.inc
   @@ -359,29 +481,61 @@ function features_menu_link_load($identifier) {
   +  $internal_path = '';
   +  $uri = explode('/', $link_path);
   +  if (module_exists('uuid') && $uri[0] == 'uuid' && count($uri) == 3) {
   +    $entity_data = uuid_uri_array_to_data($uri);
   +    $entities = entity_uuid_load($entity_data['entity_type'], array($entity_data['uuid']));
   +    if (!empty($entities)) {
   +      $entity = reset($entities);
   +      $internal_uri = entity_uri($entity_data['entity_type'], $entity);
   +      $internal_path = $internal_uri['path'];
   +    }
   +  }
   

@ciss (#36)
Thanks for pointing this out!
I suggest to open a new issue and then link between them.

@ciss, please post the patch here or to a new issue and please add a link to that issue here so that I am notified.

@donquixote @joseph.olstad Created #3085880: Revisit UUID handling for menu links as follow-up.

Revert in #3162806: Revert introduction of UUID entity path for menu links from #2353585. before next release.
Explanations there.