I refactored the two related issues and combined them into a single patch as we needed both issues resolved.

The "Menu links do not support 2+ links with same menu_name/link_path":

  • Older menu exports will import their menu items but the feature will be in overridden state till they are updated
  • Importing the new style menu links will not remove older menu items that should have been "replaced". This is because matching is only done on a unique ID and never by path or title. Menu items will need to be deleted manually.
  • Menu items that are added by things like panels or views should not be in code in both a menu link feature and the panel / view feature. Before, the menu link was smart enough to match by path or title but now it only matches by unique ID.
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mattsqd created an issue. See original summary.

mattsqd’s picture

mattsqd’s picture

Updated to allow upgrading already exported menu items as well as handling parent identifiers better.

Status: Needs review » Needs work

The last submitted patch, 3: features-link-uuid-and-export-by-unique-id-2556151-3-D7.patch, failed testing.

mattsqd’s picture

Fixed missing mlid issues.

mattsqd’s picture

Status: Needs work » Needs review
DamienMcKenna’s picture

Status: Needs review » Needs work

This needs a reroll, it no longer applies cleanly after #2353585: UUID export and import of menu items linking to nodes, terms and users was committed.

DamienMcKenna’s picture

Status: Needs work » Closed (duplicate)

You know, all of these changes were committed separately.