[D7] Simple YouTube Embed

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2352997

Project 2: https://www.drupal.org/node/2146995

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxmosewrite2137455git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

I did a manual review of the code.

The comments in the module don't seem to adhere to Drupal coding standards in terms of placing of blank lines and use of proper sentence case/structure/punctuation. The style of comments should be consistent.

e.g.

/**
 *
 * simple_youtube_embed_node_view() - hook of hook_node_view() that
 * changes the node body markup to the new markup with a youtube iframe
 * replacing the shortcode
 *
 */

should be

/**
 * Implements hook_node_view().
 *
 * This function changes the node body markup to the new markup
 * with a youtube iframeeplacing the shortcode.
 */

You need a blank line at end of the file.

I'm thinking you should also abstract out the embed code on line 89 to a theme function - that's the proper way to do it, the rule of thumb being that if you are outputting markup then a themer should be able to override it, so put it in a theme function.

You shouldn't be working off a master branch - it should be a major version branch.

Lastly, I can't help but feel you should be doing some manner of filter_xss() on your shortcodes when you are going to display them: otherwise you are in effect displaying unfiltered user inputted data, which is a bad idea. I know the risk is mollified by the fact that the user has to have full_html access anyway, but still, I think you should at least filter it for cross site scripting.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.