(First, verify that the preprocess changes have been made. #2322163: [meta] Consensus Banana Phase 1, move CSS classes from preprocess to twig templates.)

  1. Copy the Twig templates from the core module's templates directory to Classy's templates directory. Include all templates, even ones without classes.
  2. Remove all classes from the core module's template. Remove all classes added with addClass and ones that are hard-coded in the template.
  • If there are classes that are required for basic functionality, discuss whether they should be kept.
  • If there is CSS from the module, or anywhere else, referring to the class, discuss removing it or moving it to Bartik&Seven. Do not move the CSS to Classy.

Twig Templates to Copy

core/modules/ckeditor/templates/ckeditor-settings-toolbar.html.twig

Files: 
CommentFileSizeAuthor
#3 copy_ckeditor_templates-2349647-3.patch4.85 KBmortendk
FAILED: [[SimpleTest]]: [PHP 5.5 MySQL] Unable to apply patch copy_ckeditor_templates-2349647-3.patch. Unable to apply patch. See the log in the details link for more information. View

Comments

emma.maria’s picture

Assigned: Unassigned » emma.maria
emma.maria’s picture

Assigned: emma.maria » Unassigned
mortendk’s picture

Status: Active » Needs review
Issue tags: +cssbanana
FileSize
4.85 KB
FAILED: [[SimpleTest]]: [PHP 5.5 MySQL] Unable to apply patch copy_ckeditor_templates-2349647-3.patch. Unable to apply patch. See the log in the details link for more information. View

cleaned up & moved template

mortendk’s picture

Issue tags: +drupalhagen
runand’s picture

Assigned: Unassigned » runand
runand’s picture

Assigned: runand » Unassigned
Status: Needs review » Reviewed & tested by the community

Looks fine to me

lauriii’s picture

Status: Reviewed & tested by the community » Needs work

Template is not generated to classy

lauriii’s picture

Status: Needs work » Reviewed & tested by the community

Works with git apply. Sorry for causing drama :P

davidhernandez’s picture

Sholdn't this be postponed, since the ckeditor preprocess issue hasnt been done?

lauriii’s picture

Status: Reviewed & tested by the community » Needs review

Thats a good point. Putting back to Needs review until that has been discussed properly

davidhernandez’s picture

Status: Needs review » Postponed
davidhernandez’s picture

Please double-check if any removed classes are being used in javascript. It is best to test the affected template using Stark to make sure nothing is broken.

mgifford’s picture

Status: Postponed » Needs review
Related issues: +#2329781: Move CKEditor toolbar classes from preprocess to templates

Ok, that's in.

Status: Needs review » Needs work

The last submitted patch, 3: copy_ckeditor_templates-2349647-3.patch, failed testing.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.