Tested in Drupal 8.0.0-beta1
I just tried doing the CKeditor toolbar configuration and found that it wasn't necessarily obvious, both in the drag-and-drop mode and in the keyboard mode.
On /admin/config/content/formats/manage/full_html
In drag-and-drop mode:
1. If group names are hidden, e.g., in the initial page state, and I drag a button from available buttons to active toolbar, the group names show. This is surprising.
2. I would up playing chase the group a few times before I realized that I had to make sure I didn't accidentally cursor over some other group. I tried to place the maximize button into a new Use group. When going toward a Use group in the 2nd row over to the right, I kept accidentally brushing against the Redo Undo group, causing Redo Undo to grab focus and the Use group to jump over to 3rd row left.
Then trying to drag over to Use group in 3rd row left, I would overshoot it slightly to the bottom and go over the double line, upon which Use would jump over to 2nd row right again as Redo Undo shrunk and made room for it.
I had several unsuccessful tries. The attached image shows me at the end of trying to move Maximize to a 2nd-row-right Use group, accidentally grazing Redo Undo, and Use jumping to 3rd-row-left.
I eventually after several tries carefully avoided grazing the Undo Redo group and successfully placed the Maximize button in the 2nd-row-right Use group. But it was no fun.
I also gave keyboard access a try:
If I want to move several buttons in a row from Available to Active or vice versa:
1. I tab to one button.
2. I press the down arrow (Available to Active) or up arrow (Active to Available).
3. I have to press the right (and left if I overshoot) arrow potentially many times to position the button.
3. I now have to tab forward or back many times to get back to the spot I was at in the original array of buttons. There doesn't appear to be a back-to-where-you-were-in-the-original-array keyboard sequence.
Other suggestions:
I'm feeling a bit of the "This is a wonderful new feature and you must use it" to the way this has been implemented. I'd really rather not be forced to interact with it in a graphic format. Just because I can drag-and-drop doesn't mean I always enjoy it. For those of us in that category, I suggest the following:
- Allow adding or removing buttons by checklist, same as in the CKEditor in Drupal 7.
- Provide an equivalent to Show/hide row weights for sequencing the buttons and between-group spaces.
- Provide help as to exactly how to move the buttons with the arrow keys, e.g., that left and right arrows only work within the Active toolbar.
Comments
Comment #1
charles belovComment #6
richardbmcdonald commentedI have had great trouble moving the toolbar buttons around with the arrow keys. In fact, I have not been able to do it at all but, rather, have had to have a sighted person do it for me with the mouse. The changes requested here - using checkboxes and row weights - is exactly what needs to be done. Is this fix expected to be in the D8.4 release? If nothing else, the help text for moving the buttons with the arrow keys needs to be updated per Charles' instructions here (i.e., tabbing, up/down arrow keys to move between "available"/"active" and left/right arrow keys to position within toolbar groups). The current help text does not indicate this method. As such, I have not tried this method yet. I will try it shortly, and then report back. But, irrespective of my result, Charles' method suggested here is FAR better and should be implemented.
Comment #7
richardbmcdonald commentedI (hope) I added the "accessibility" tag to this!
Comment #8
andrewmacpherson commentedMoving this back to the CKEditor module component, because that's where this interface code lives.
Comment #9
richardbmcdonald commentedWell, I tried again to move the toolbar buttons using the instructions posted in this issue (i.e., the keyboard) but am still not able to do it. The instructions posted here are *better* than those provided in the actual configuration page, though still inadaquate, at least for me. When at the configuration page, indeed when I tab onto a button I hear JAWS say "press down to activate", but when I then do that it just moves to the next button without actually doing anything. Retrying it, after tabbing onto a button and hearing the foregoing, I then press the spacebar. *Something* happens, but I am not sure exactly what. I think maybe it goes into "form mode", and the button is then selectable. However, somehow I get into the "active" buttons area and I then hear JAWS speaking a bunch of stuff like "position x of y, . . ." - but it really is just too much. I still cannot figure out whether I actually marked a button for moving nor actually how to place it. I gave up at this point. Again, this is just all too much. Charles' checkbox/row weight method suggested in this issue is the way forward here. Until then, I would not consider this functionality accessible, and will need sighted asssistance from someone using a mouse to drag/drop these buttons.
Comment #14
othermachines commentedThis seems like a good place to add that we should be able to delete groups as well as add them via the UI. After adding a group and then changing my mind, I only accidentally discovered that an empty group will be removed when you save the form.
Comment #18
quietone commentedCKEditor has been removed from core, CKEditor 4 is removed from Drupal Core in 10.0.0