Follow-up to #2080823: Create API to discover config entities' soft dependencies and use this to present a confirm form on module uninstall

There's 2 @todo left in code

$ git grep 2080823
core/modules/field/field.purge.inc:91:    // @todo Revisit after https://www.drupal.org/node/2080823.
core/modules/field/field.purge.inc:119:    // @todo Revisit after https://www.drupal.org/node/2080823.
Files: 
CommentFileSizeAuthor
#13 2343517-10-reroll.patch1.57 KBjoelpittet
#10 2343517-10.patch1.58 KBjoelpittet
#4 2343517-4.patch2.3 KBrteijeiro
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 84,118 pass(es), 22 fail(s), and 0 exception(s). View

Comments

andypost’s picture

Issue summary: View changes
xjm’s picture

Issue tags: -beta blocker +beta target
xjm’s picture

Title: Cleanup @todo after 2080823 » Cleanup @todo referring to the config dependencies API issue
Issue tags: -VDC
rteijeiro’s picture

Status: Active » Needs review
FileSize
2.3 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 84,118 pass(es), 22 fail(s), and 0 exception(s). View

Not sure if this is what it's expected. Let me know if not.

Status: Needs review » Needs work

The last submitted patch, 4: 2343517-4.patch, failed testing.

andypost’s picture

Issue summary: View changes
Issue tags: -beta target

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Mile23’s picture

Version: 8.1.x-dev » 8.2.x-dev
Priority: Normal » Major
Related issues: +#2782009: Create a field with the same name as one being purged results in data destruction of the new field

Moving to 8.2.x and Major because it's almost a duplicate of #2782009: Create a field with the same name as one being purged results in data destruction of the new field which is critical.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

joelpittet’s picture

Status: Needs work » Needs review
FileSize
1.58 KB

Not sure if this is major, but here's a re-roll of #4 which only affects
core/modules/field/field.purge.inc

Status: Needs review » Needs work

The last submitted patch, 10: 2343517-10.patch, failed testing.

joelpittet’s picture

Interesting failure:

fail: [Fatal error] Line 0 of :
[23-Feb-2017 08:09:33 Australia/Sydney] Uncaught PHP Exception Drupal\Component\Plugin\Exception\PluginNotFoundException: "The "block_content" entity type does not exist." at /var/www/html/core/lib/Drupal/Core/Entity/EntityTypeManager.php line 133

joelpittet’s picture

Status: Needs work » Needs review
FileSize
1.57 KB

Reroll

Status: Needs review » Needs work

The last submitted patch, 13: 2343517-10-reroll.patch, failed testing.