This module aims to provide a vCard attachment for views in a similar way as the views built in feeds system does.

The existing vCards modules vCard and vCard Field work with either Profile2 data, or data the user has to enter himself. There was however no solution for websites that use the Core profile system. This module attempts to fill that gap.

Sandbox:
https://www.drupal.org/sandbox/neograph734/2270885

Clone:

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/Neograph734/2270885.git

As of now there is no simple way to export existing users as vCards within Drupal. Since our organization (and probably many others) already have an existing database of users base on the Drupal Core profiles there is no conversion to other vCard modules. Which either requires Profile2 fields, or add a new fieldset to the the user profile that has to be filled in manually.
This module can expose all fields that are known to a user entity in Views and add them to a downloadable vCard. When a selection contains multiple vCards, they get zipped using an external library and the Library API. (See project page for download.)

Comments

PA robot’s picture

PA robot CreditAttribution: PA robot commented
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxNeograph7342270885git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Neograph734’s picture

Neograph734
he/him
Location Netherlands
CreditAttribution: Neograph734 commented

Pareview is trowing a lot of errors regarding my classnames (undersores and lowercase), however since I followed the way other Views modules are built, do I need to fix this or can I neglect these errors?

abogomolov’s picture

abogomolov CreditAttribution: abogomolov commented

Hi Neograph734,

I'm not sure about the Views classes, but you shold reformat your code.

Neograph734’s picture

Neograph734
he/him
Location Netherlands
CreditAttribution: Neograph734 commented

Thanks for the feedback, I already started that (however in Views it was done in a similar way as well).
But I'll make sure it becomes as it shoud :)

Neograph734’s picture

Neograph734
he/him
Location Netherlands
CreditAttribution: Neograph734 commented
Status: Needs work » Needs review

Difficult logic constructors and doc blocks are now max 80 lines. I'm still curious about the Views classes as this is the style used by that module.

stitchzdotnet’s picture

stitchzdotnet CreditAttribution: stitchzdotnet commented
Status: Needs review » Needs work

Hi Neograph734

I'd suggest the following:

  • Follow the coding standards and use the results of the automated code review tool to update your code. The Views classes may have been written before the current coding standards and not updated yet.
  • Check out the Drupal documentation and comment standards (https://www.drupal.org/coding-standards/docs) for examples on commenting function parameters. For example, I'd suggest adding some @param comments in the views_vcards_theme function to clarify what each parameter is used for.
  • Inline comments are sparse (i.e. views_vcards_plugin_style_vcard.inc), adding additional inline comments will help in future troubleshooting and/or debugging and also reviewers manually walking through your code.
  • README.txt installation instructions could use some more details. It may seem obvious how to install a module to many, but it may not be for those new to Drupal.
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented
Status: Needs work » Needs review

That all doesn't sound like application blockers - anything else you found or should this be RTBC instead?

stitchzdotnet’s picture

stitchzdotnet CreditAttribution: stitchzdotnet commented
Status: Needs review » Reviewed & tested by the community

You're right klausi, these aren't application blockers, and after a second code review I couldn't find any so project status has been updated to RTBC.

Neograph734’s picture

Neograph734
he/him
Location Netherlands
CreditAttribution: Neograph734 commented

Thanks for all the feedback, I will have a look at the readme and the documentation as soon as I have some free time.

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
CreditAttribution: kscheirer commented
Status: Reviewed & tested by the community » Fixed

Nice looking implementation, no issues found.

Thanks for your contribution, Neograph734!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Neograph734’s picture

Neograph734
he/him
Location Netherlands
CreditAttribution: Neograph734 commented

Awesome, many thanks to all! :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.