This modules add the ability to add a field per node type that will replicate the ShareThis block.

It can be found here: https://www.drupal.org/sandbox/timodwhit/2341739

To get it working:

  1. Enable the module.
  2. This will also enable ShareThis.
  3. Configure ShareThis and select to use it as a block
  4. Go to the node edit page of your choosing.
  5. Select "Show Field" under ShareThis Field settings

To clone it down:

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/timodwhit/2341739.git bare
cd bare

Automated Review
http://pareview.sh/pareview/httpgitdrupalorgsandboxtimodwhit2341739git

Manual Reviews

Files: 
CommentFileSizeAuthor
#6 duplicate.png28.82 KBjusty

Comments

timodwhit’s picture

Issue summary: View changes
timodwhit’s picture

Issue summary: View changes
PA robot’s picture

Multiple Applications
It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2341757

Project 2: https://www.drupal.org/node/2168155

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

PA robot’s picture

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

timodwhit’s picture

Title: ShareThisField » [D7] ShareThisField
Status: Active » Needs review
justy’s picture

FileSize
28.82 KB

Thank you for your contribution!

I have manually reviewed this module and it works great in most cases.

However, there are a few issues found. Please address them.

1. There are still some issues reported by automated review tool. See http://pareview.sh/pareview/httpgitdrupalorgsandboxtimodwhit2341739git

2. Function function sharethisfield_field_extra_fields()
There seems be an undefined variable $extra.

3. In one of my test content types, the ShareThis field appeared twice, after selecting the checkbox. (see screenshot)

justy’s picture

Status: Needs review » Needs work

forget to change the status

timodwhit’s picture

Status: Needs work » Needs review

Justy, thank you so much for taking the time to review the module!

1) Fixed the line length warnings. Didn't see any other issues.

2) Just saw this. Should be corrected.

3) I believe the dup is because you have ShareThis display per content type and not as a block. I added a check for that so now if the content type is selected, the module won't show the field.

Thank you again for reviewing, I greatly appreciate it!

naveenvalecha’s picture

Issue summary: View changes

Updated issue summary.

naveenvalecha’s picture

Issue summary: View changes
naveenvalecha’s picture

Awesome module!
I suggest to add the package as "SHARING" in sharethisfield.info file.As sharethis module has the same package.
Please add some more information about the project so that I can review its full functionality.

skorzh’s picture

Status: Needs review » Needs work

Hey, the code looks very clear, but there are some small issues:
1) It's not necessary to wrap name and description to double quotes in .info file, check https://www.drupal.org/node/542202
2) You have to remove all created variables in hook_uninstall()

timodwhit’s picture

@naveenvalecha : Thanks for the tip on Sharing, That has been added. As far as the more information, what specifically are you looking for?

@korgik: Thank you for the help. Both changes have been implemented.

naveenvalecha’s picture

@timodwhit,
have u done the requested changes ? and if you wanna someone will review the code then change the issue status to 'Needs Review'.

timodwhit’s picture

Status: Needs work » Needs review

@naveenvalecha sure have. Thanks for that.

naveenvalecha’s picture

Status: Needs review » Needs work

Cool!
Some few points need to fix which are release blocker:

  1. Improve Readme.txt file.Does not follow the guidelines for in-project documentation and/or the README Template.
  2. Add hook_help in module.
klausi’s picture

Status: Needs work » Needs review

hook_help() and an incomplete README are surely not application blockers, anything else that you found or should this be RTBC instead?

naveenvalecha’s picture

Status: Needs review » Reviewed & tested by the community

Yup not found anything else that seems to be the Release blocker. Love to set this RTBC :)

naveenvalecha’s picture

@timodwhit,
you need Review bonus to come in high priority list so that git administers will take a look at your application.

kscheirer’s picture

Status: Reviewed & tested by the community » Postponed (maintainer needs more info)
Duplication
This sounds like a feature that should live in the existing ShareThis project. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please open an issue in the ShareThis issue queue to discuss what you need. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.

If that fails for whatever reason please get back to us and set this back to "ready to be committed".

If all this module does is provide the sharethis block as a field, it seems like it should belong in the ShareThis module.

timodwhit’s picture

Status: Postponed (maintainer needs more info) » Closed (duplicate)