Closed (duplicate)
Project:
Drupal.org security advisory coverage applications
Component:
theme
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
6 Jan 2014 at 18:42 UTC
Updated:
9 Sep 2018 at 22:31 UTC
Jump to comment: Most recent
Comments
Comment #1
ram4nd commentedFor starters you can remove .gitignore files and follow https://drupal.org/empty-git-master
Comment #2
timodwhit commented@ram4nd, thanks for catching those and the information.
They have been removed and updated. Much Appreciation!
Comment #3
klausiI guess this needs review? See the project application workflow.
Comment #4
PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxtimodwhit2164835git
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #5
timodwhit commentedFixed issues, resetting to Needs Review.
Comment #6
timodwhit commentedFixed issues, resetting to Needs Review.
Comment #7
ryanblyth commentedLooks good, reviewed.
Comment #8
ryanblyth commentedComment #9
pingwin4egGit clone command for the sandbox is missing in the issue summary, please add it.
There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxtimodwhit2164835git-7...
Comment #10
timodwhit commented@pingwin4eg Thank you for the review.
I have gone through and fixed the issues from pareview. Also, added the git clone command.
Comment #11
pingwin4egSorry, maybe I expressed my thought incorrectly, but the git clone command should be here in this issue, and not on the project page.
Also I don't exactly know if multiple-versioned projects should be reviewed in whole or only one of the branches, but I think that in your git clone command you should specify that branch that corresponds to this issue title [D7]. Or vise versa.
And one more thing - use non-maintainer URL in the clone command. That you specified is available only for you, it is not public. Go to the Versioning tab from your sandbox, there you can find the public URL of your project's repo.
Comment #12
timodwhit commentedComment #13
timodwhit commented@pingwin4eg Thank you for the help with that. Changes made.
Comment #14
rymcveighBeen using this theme for a while now and like it, works great for me.
Comment #15
PA robot commentedProject 1: https://www.drupal.org/node/2341757
Project 2: https://www.drupal.org/node/2168155
As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).
If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #16
avpadernoComment #17
avpaderno