Add social share buttons with folating sidebar on your drupal site.Using "Social Share Buttons" module ,you can share your website on social sites with your friends. (Facebook,Twitter,Linkedin,Google+,Pinterest,Mail)
Project Page
https://www.drupal.org/sandbox/raghunathgurjar/2326107
GIT
git clone --branch 7.x.-1.x http://git.drupal.org/sandbox/raghunathgurjar/2326107.git social_share_buttons
Automated Review
http://pareview.sh/pareview/httpgitdrupalorgsandboxraghunathgurjar232610...

Files: 
CommentFileSizeAuthor
social_share_buttons.zip12.76 KBraghunath.0087

Comments

raghunath.0087’s picture

Title: Social Share Buttons » [D7] Social Share Buttons
Assigned: raghunath.0087 » Unassigned
naveenvalecha’s picture

Hi Raghunathan
Thanks for showing your interest in the drupal. For publishing your module you need to first create the project at your sandbox environment.

Please read Contribute to development, Joining forces with others, and Best practices for creating and maintaining projects.

Thanks
Naveen Valecha

naveenvalecha’s picture

Status: Needs review » Needs work

Changed status

raghunath.0087’s picture

Hi naveen,

Thanks for reply!

This is my first module for drupal so i am new about how to upload a new module on wordpress. so can you please help me

i this one the my sandbox link for my module
https://www.drupal.org/sandbox/raghunathgurjar/2326107

Please check and let me know if anything missing in my module for make to to full project or use for genereal purpose.

naveenvalecha’s picture

Hi Raghunathan
Thanks for doing the same.
you need to push your code on the drupal using git. Read instructions here https://www.drupal.org/project/2326107/git-instructions

P.S. : For any project we need to push the code in git for the better management of code.

Thanks
Naveen Valecha

naveenvalecha’s picture

Status: Needs work » Closed (duplicate)

Hi Raghunathan
Thanks for the update. Great start and good contribution :). After checking the module this type of sharebar module https://www.drupal.org/project/sharebar already exists on drupal.

As this type of module already exists so the duplicate projects can't be published on the drupal.Please let me know if your module is different from this one and feel free to change the status of this issue.

Thanks
Naveen Valecha

raghunath.0087’s picture

hello naveen,

Thanks for give a quick reply!

My moduleis different of this module..my module is providing only custom share buttons with custom images. i have created my own code for this module,,i have not used exist code of any modules

and also i don't know about git... as per git instruction we have need to run some command but this is only possible in linux i am using windows8 so how i can use this. i have installed git software but i dont know how i can take checkout and how i can commint my code using git.

Can you please help me!

Thanks for help!

Thanks
Raghunath

raghunath.0087’s picture

Status: Closed (duplicate) » Needs review
PA robot’s picture

Status: Needs review » Needs work

Git clone command for the sandbox is missing in the issue summary, please add it.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

naveenvalecha’s picture

Hi Raghunathan,

My module is different of this module..my module is providing only custom share buttons with custom images. i have created my own code for this module,,i have not used exist code of any modules

Thanks for letting me know. I will look at the code by later today and then let you know.

and also i don't know about git... as per git instruction we have need to run some command but this is only possible in linux i am using windows8 so how i can use this. i have installed git software but i dont know how i can take checkout and how i can commit my code using git.

Please read https://www.drupal.org/documentation/git
This will help you. Please let me know after pushing the code and change the status to "Needs Review"

Thanks
Naveen Valecha

raghunath.0087’s picture

Status: Needs work » Needs review

hi naveen,

i have added module core files on git as per instruction given on this link https://www.drupal.org/project/2326107/git-instructions

can you please have a look into this? i am not sure that i have done all is properly or not

Thanks
Raghunath

naveenvalecha’s picture

Status: Needs review » Needs work

Hi Raghunathan
Thanks for committing the code to the git.Keep up the efforts.

Automatic Review

I'll be great if you include a link to pareview:
http://pareview.sh/pareview/httpgitdrupalorgsandboxraghunathgurjar232610...

Manual Review

README.txt

No: The readme is not present. And the project page is not clear too.Too many categories are added on the project page.

Master Branch

No: It does not have a default branch defined.

Unused Code

Remove Unused Code

// jQuery - diese Scripte nur auf Startseite einbinden
/* 
if ($vars['is_front']) {
drupal_add_js(drupal_get_path('theme', 'garland') . '/js/plugin.js');
drupal_add_js(drupal_get_path('theme', 'garland') . '/js/script.js', array('scope' => 'footer', 'weight' => 99));
}*/

Coding style & Drupal API usage

  • Instead of using jQuery(document).ready, Use Drupal.behaviors.
  • Specify the comments above the hooks, like hook_preprocess page.

As I am not a git administrator, so I would recommend you, please help to review other project applications to get a review bonus. This will put you on the high priority list, then git administrators will take a look at your project right away :-)

Thanks
Naveen Valecha

raghunath.0087’s picture

Status: Needs work » Needs review

Hello Naveen,

I have done need full changes, so can you please check my module.

Thanks for help!

Thanks
Raghunath

gaurav.pahuja’s picture

Status: Needs review » Needs work

Hi Raghunathan,

Code that has been checked in into GIT doesn't seems to be valid code.

Please clone it again and try to look into module file.

Command that I used for cloning branch:

git clone --branch 7.x.-1.x http://git.drupal.org/sandbox/raghunathgurjar/2326107.git social_share_buttons

raghunath.0087’s picture

Status: Needs work » Needs review

Hello Gaurav,

I have clone the code so please check now and let me know your feedback.

Thanks
Raghunath

pkamerakodi’s picture

Hi,

Could you please check the code you have committed to git, looks like there is a conflict in it.

Prajwal

pkamerakodi’s picture

Status: Needs review » Needs work
naveenvalecha’s picture

Issue summary: View changes

Updated issue summary.
Please fix the errors identified by the pareview
http://pareview.sh/pareview/httpgitdrupalorgsandboxraghunathgurjar232610...

PA robot’s picture

Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.