[D7] Social Share Buttons

Hi Raghunathan
Thanks for showing your interest in the drupal. For publishing your module you need to first create the project at your sandbox environment.

Please read Contribute to development, Joining forces with others, and Best practices for creating and maintaining projects.

Thanks
Naveen Valecha

Changed status

Hi Raghunathan
Thanks for doing the same.
you need to push your code on the drupal using git. Read instructions here https://www.drupal.org/project/2326107/git-instructions

P.S. : For any project we need to push the code in git for the better management of code.

Thanks
Naveen Valecha

Hi Raghunathan
Thanks for the update. Great start and good contribution :). After checking the module this type of sharebar module https://www.drupal.org/project/sharebar already exists on drupal.

As this type of module already exists so the duplicate projects can't be published on the drupal.Please let me know if your module is different from this one and feel free to change the status of this issue.

Thanks
Naveen Valecha

Git clone command for the sandbox is missing in the issue summary, please add it.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi Raghunathan,

My module is different of this module..my module is providing only custom share buttons with custom images. i have created my own code for this module,,i have not used exist code of any modules

Thanks for letting me know. I will look at the code by later today and then let you know.

and also i don't know about git... as per git instruction we have need to run some command but this is only possible in linux i am using windows8 so how i can use this. i have installed git software but i dont know how i can take checkout and how i can commit my code using git.

Please read https://www.drupal.org/documentation/git
This will help you. Please let me know after pushing the code and change the status to "Needs Review"

Thanks
Naveen Valecha

Hi Raghunathan
Thanks for committing the code to the git.Keep up the efforts.

Automatic Review

I'll be great if you include a link to pareview:
http://pareview.sh/pareview/httpgitdrupalorgsandboxraghunathgurjar232610...

• It says you must define the default branch. Here's the documentation: https://www.drupal.org/node/1659588
• README.txt or README.md is missing, see the guidelines for in-project documentation. https://www.drupal.org/node/447604

Manual Review

README.txt

No: The readme is not present. And the project page is not clear too.Too many categories are added on the project page.

Master Branch

No: It does not have a default branch defined.

Unused Code

Remove Unused Code

// jQuery - diese Scripte nur auf Startseite einbinden
/* 
if ($vars['is_front']) {
drupal_add_js(drupal_get_path('theme', 'garland') . '/js/plugin.js');
drupal_add_js(drupal_get_path('theme', 'garland') . '/js/script.js', array('scope' => 'footer', 'weight' => 99));
}*/

Coding style & Drupal API usage

• Instead of using jQuery(document).ready, Use Drupal.behaviors.
• Specify the comments above the hooks, like hook_preprocess page.

As I am not a git administrator, so I would recommend you, please help to review other project applications to get a review bonus. This will put you on the high priority list, then git administrators will take a look at your project right away :-)

Thanks
Naveen Valecha

Hi Raghunathan,

Code that has been checked in into GIT doesn't seems to be valid code.

Please clone it again and try to look into module file.

Command that I used for cloning branch:

git clone --branch 7.x.-1.x http://git.drupal.org/sandbox/raghunathgurjar/2326107.git social_share_buttons

Hi,

Could you please check the code you have committed to git, looks like there is a conflict in it.

Prajwal

Updated issue summary.
Please fix the errors identified by the pareview
http://pareview.sh/pareview/httpgitdrupalorgsandboxraghunathgurjar232610...

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.