[D7] Image Caption & More

Hi MissterX,

There is no need to assign it to anyone. Changing it to Unassigned.
As for the code, few changes are required

Line 3, file README.html
If your are the <a href="/admin/config/media/img_capt/admin">siteadmin, use this link.</a>
The link does not have the Base URL. So it will redirect on the 404 error page (see the screencast: screencast.com/t/nhnLhyDRD)

Line 252, file img_capt.module
Always use t() function for translation.

'#options' => array('TITLE' => 'TITLE', 'ALT' => 'ALT'),

should be

'#options' => array('TITLE' => t('TITLE'), 'ALT' => t('ALT')),

Multiple lines, file img_capt.module

if ($form_state['input']['op'] == t('New setting')) {

}

while comparing $form_state['values'] should be used as $form_state['input'] are raw and unvalidated.
Problem is $form_state['values'] ignores the default value. When the submission fails $form_state['values'] give the NULL value instead of the default value.

Line 3, file README.txt
Follows Guidelines content-wise although "About Image Caption & More" should be "Introduction". Also few Spelling errors are there.

Automated Review

For the beginning, you can addres the errors found by pareview.sh:

http://pareview.sh/pareview/httpgitdrupalorgsandboxmissterx2319551git

It found a lot of unused variables for example.

Manual Review

Individual user account

Yes: No clues that it would be a one of many accounts.

No duplication

Yes: I couldn't find any module that would be essentially the same.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Not sure yet: Are you an author of this "gears.png" graphic?

3rd party code

Yes: Follows the guidelines for 3rd party code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes. Didn't find anything.

Coding style & Drupal API usage

To say more, you need to clean up a code per pareview.sh suggestions where it's possible.

At the beginning of the img_capt_image_caption() function is this:

  $go_on = FALSE;
  if (($library = libraries_load('simple_html_dom')) && !empty($library['loaded'])) {
    $go_on = TRUE;
  }

  if (!$go_on) {
    drupal_set_message($library['error message'], 'error');
  }

But it doesn't stop the function from going on, you need to return something beyond setting a message.

Also, If you are using html docs with images, I would consider to put them all in /docs directory .

This review uses the Project Application Review Template.

Automated Review

So far fix all problems listed here http://pareview.sh/pareview/httpgitdrupalorgsandboxmissterx2319551git

Manual Review

Individual user account
Yes
No duplication
Yes
Master Branch
Yes
Licensing
YES
3rd party code
Yes
README.txt/README.md
Yes
Code long/complex enough for review
Yes
Secure code
Yes
Coding style & Drupal API usage
Everything seems to be OK, but you should fix all errors listed on http://pareview.sh/pareview/httpgitdrupalorgsandboxmissterx2319551git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hello MIssterX,

I saw your code, just found some issue

1. Variable name always be meaningful, please change some variable name you are using variable name link $s, $c_t.

2. Don't use #prefix and #suffix for a whole form if you want a wrapper in some form element then use #container.

https://api.drupal.org/api/drupal/developer!topics!forms_api_reference.h...

3. Please use isset while taking data from any object or array,

if any node doesn't have anything in bode field then it will through an error

if ($setting['content_type'] == $node->type) {
$doc = $node->content['body'][0]['#markup'];
$node->content['body'][0]['#markup'] = img_capt_image_caption($doc, $node->type);
break;

4. please put module configuration link in module info file.

1.
/**
* Implements hook_help_desc().
*/
function img_capt_help_desc() {

I don't think there is a hook_help_desc. So please add appropriate comments.

2.
$path = drupal_get_path('module', 'img_capt');
drupal_add_css($path . '/css/admin-page.css');
drupal_add_css($path . '/css/caption.css');
$help_file = file_get_contents(drupal_get_path('module', 'img_capt') . '/docs/README.html');

First you use $path then you call drupal_get_path again maybe you forgot it.

3. Think about setting the permission "img_capt" maybe in the install hook for administrators

4. In project issue and sandbox add info that there is "libraries" dependancy

5.
else {
$loaded_setting = '0';
}
if ($loaded_setting == '0') {
$loaded_setting = 'Default';
}
Why not else { $loaded_setting = 'Default'; don't loose bytes in such things

6. Do not use:
drupal_add_css($path . '/css/admin-page.css');
drupal_add_css($path . '/css/caption.css');

to add css or drupal_add_js to add js in forms because on submit you loose them and if you have an error you wont have styling so
better use $form['#attached']['css'] and $form['#attached']['js']

7. There is no such thing:

/**
* Implements hook_admin_validate().
*/

8. img_capt_admin_validate is only called by img_capt_ajax_load_setting so you dont need to repeat this:
if (!user_access('administer img_capt')) {
drupal_access_denied();
drupal_exit();
}

9. Consider passing your $form_state by reference on all form functions for proper function declaration.

These are the things i saw on first glance for the first 2-3 hundred rows so please check and fix them and then i can continue with review
if needed.

Based on @ShaxA review this module need some more love (work).

If you are still working on this module please perform the necesarry changes, othervise please help the webmasters work by closing this ticket.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.