[D7] Most Popular RSS

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxjemilco2316651git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Formatting issues have been addressed. Please review.

I have performed a manual review of your code and found following issues.

1. There is still a master branch, make sure to set the correct default branch. see this article at https://www.drupal.org/node/1659588. Then also remove master branch, see this article at https://www.drupal.org/node/1127732

2. In code module review, i found below warning message.
File: @file block missing in module file.

3. This module is throwing following notices at /admin/config/mostpopular/intervals, you should fix these.

- Notice: Trying to get property of non-object in mostpopular_rss_feed_page() (line 123 of \most_popular_rss\mostpopular_rss.module).
- Notice: Trying to get property of non-object in mostpopular_rss_feed_page() (line 122 of \most_popular_rss\mostpopular_rss.module).

4. README.md - it doesn't follows standard README Template(https://www.drupal.org/node/2181737).

Thanks

Repository link that you provided seems to be incorrect.

It should be
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/jemilco/2316651.git most_popular_rss

@cejams, thankyou for your contribution.

Automated Review

Best practice issues identified by pareview.sh / drupalcs / coder. None.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and fragmentation.

Master Branch

(*) No: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements

3rd party code

Yes: Follows the guidelines for 3rd party code.

README.txt/README.md

(+) No: Follows the guidelines for in-project documentation and the README Template. There is no info on how to use or configure this, or how it works.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

No. If "no", list security issues identified.

1. In mostpopular_rss_menu(): The menu callback is using "user_access" but a separate permission would be good, too.
2. mostpopular_rss_feed_page(): md5() should not be used for anything security related. You should use drupal_hmac_base64() instead. Can you just use drupal_get_token() instead?

Coding style & Drupal API usage

1. (+) When I am trying to access mostpopular/%/%/%/rss.xml, producing following warnings.
   
   
   
2. hook_help() is missing in your module.
3. (+) mostpopular_rss_feed_page(): Instead of using gmdate, better to use format_date().
4. Project Page also contains very few information, go through from this page (https://www.drupal.org/node/997024) again.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

Please don't remove the security tag, we keep that for statistics and to show examples of security problems.

As I am not a git administrator, so I would recommend you, please help to review other project applications to get a review bonus. This will put you on the high priority list, then git administrators will take a look at your project right away :-)

Thanks Again!

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.