Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Follow-up to #2300347: Regression: checkbox to enable translation for users does not save
Problem/Motivation
Steps to reproduce:
1. install Drupal8.
2. enable language and content_translation modules.
3. navigate to Administration -> Configuration -> People.
4. under "Language Settings", click the checkbox to enable translation.
Expected:
Check if there at least a field with translation option.
Actual:
Allows to save.
Proposed resolution
We got two options:
1. Do the validation in content_translation_form_language_content_settings_validate to display the translate field
2. Get ride of the field in entity config form, so that the only way to update will be admin/config/regional/content-language page.
Remaining tasks
User interface changes
Yes, depending on the solution we go with.
API changes
N/A
Comments
Comment #1
vijaycs85Comment #2
Gábor HojtsyI don't believe that this would be a regression. It is just that when you are on the entity config / content type form, you NEED to enable translation support for the fields to be possible to be enabled for translation. So you cannot make a field translatable BEFORE you make the entity bundle. We cannot make it an error because then you cannot go ahead. So with these forms, you can end up in different situations compared to the main configuration wizard, where this is not possible.
Not sure what is better, to remove the settings or not. If we remove, then when you create new things, eg. a menu, content type, etc. you cannot configure translatability. You would need to then go to a different place to configure it :/ On the other hand, with the current form process there, you need to go through multiple steps also to configure the fields, and maybe doing all that would be best on the wizard page in the first place. So maybe you need to work too much to configure it either way, and then we should rather focus you to go to the wizard page. Hum.
Comment #3
Gábor Hojtsy#2355909: language.settings config is not scalable suggests the opposite of this issue and says the entity settings should have this configuration (UI and config) and not a one page wizard.
Comment #4
penyaskitoWhat should we do with this one?
Comment #5
Gábor Hojtsy*I* think it would be better usability if we only have the wizard screen and not the per-entity settings due to misunderstandings like this issue (and to avoid people biting themselves with this one).
Comment #6
penyaskito@vijaycs85 and I were discussing this a couple of days ago, and he proposed a third option: remove the settings from the entity form, but leave a link to the wizard page. This way people used to D6-D7 will also find the wizard quickly.
Comment #7
Gábor HojtsySounds fine to me.
Comment #8
Gábor Hojtsy#1893596: Can we remove field's own translatable setting from UI? is the same for the field settings page.
Comment #19
larowlanThis sounds like a feature request now, but going with the middle ground of task