Problem/Motivation

While going through comment #6 in #2301239: MenuLinkNG part1 (no UI or conversions): plugins (static + MenuLinkContent) + MenuLinkManager + MenuTreeStorage reviewing @todos in MenuTreeStorage.php and MenuLinkManager notice the definition of fields need to be in sync.

Proposed resolution

Perhaps use a new method to keep them in sync, or use array_keys

Remaining tasks

  • Use appropriate keys for field definitions in MenuTreeStorage and avoid duplication

User interface changes

No

API changes

No, but an addition might be required

CommentFileSizeAuthor
#24 interdiff_22-24.txt427 bytespooja saraah
#24 2302085-24.patch5.4 KBpooja saraah
#22 2302085-22.patch5.38 KBrishabh vishwakarma
#10 menu-keep_field_definition_in_sync-2302085-10-8.6.x.patch5.57 KBvoleger
#10 interdiff-2302085-08-10.txt5.24 KBvoleger
#8 interdiff-2302085-07-08.txt4.99 KBvoleger
#8 menu-keep_field_definition_in_sync-2302085-08-8.5.x.patch6.92 KBvoleger
#7 menu-keep_field_definition_in_sync-2302085-07-8.5.x.patch5.62 KBvoleger

Comments

pwolanin’s picture

pwolanin commented
Status: Active » Postponed

Shouldn't be worked on until after #2301319: MenuLinkNG part5: Remove dead code; and party!

mgifford’s picture

mgifford
he/him
Primary language English
commented
Status: Postponed » Active

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented
Version: 8.4.x-dev » 8.5.x-dev
StatusFileSize
new menu-keep_field_definition_in_sync-2302085-07-8.5.x.patch5.62 KB

Just try to use trait for this.

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented
Status: Active » Needs review
StatusFileSize
new menu-keep_field_definition_in_sync-2302085-08-8.5.x.patch6.92 KB
new interdiff-2302085-07-08.txt4.99 KB

Define magic properties in the trait. Add doc property definitions in related interfaces.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented
StatusFileSize
new interdiff-2302085-08-10.txt5.24 KB
new menu-keep_field_definition_in_sync-2302085-10-8.6.x.patch5.57 KB

try to just share $default property and override definitionFields() method with returning keys from $default property in MenuTreeStorage.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented

@voleger; no need to run tests for all php versions. This patch looks good, but since there are only 2 implementations, I don't think it's needed to do this refactor.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work
Issue tags: +Needs Review Queue Initiative, +Novice

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request as a guide.

Tagged for novice for beginner developers to reroll.

rishabh vishwakarma’s picture

rishabh vishwakarma commented
Status: Needs work » Needs review
StatusFileSize
new 2302085-22.patch5.38 KB

Adding patch for 10.1.x-dev. Please review.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Needs work

The phpcs failure in #22 needs to be fixed.

pooja saraah’s picture

pooja saraah commented
StatusFileSize
new 2302085-24.patch5.4 KB
new interdiff_22-24.txt427 bytes

Fixed failed commands on #22
Attached patch against Drupal 10.1.x
Attached interdiff

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Reroll looks good.

Good job @pooja saraah!

  • catch committed 475a3c73 on 10.1.x 
    Issue #2302085 by voleger, pooja saraah, Rishabh Vishwakarma, victoru:...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Looks great. Don't think we need a CR for this trait, it's quite internal but good to share the code between the two places in core.

Committed 475a3c7 and pushed to 10.1.x. Thanks!

catch’s picture

catch
he/him
Primary language English
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.