Views Argument Cache with Indexing is a Drupal 7 module derived from Views Arg Cache. Views Argument Cache with Indexing performs additional database storage of the cached view's arguments and there values which allows for additional filtering when performing a cache flush via the use of views_arg_cache_index_flush.

This module attempts to address one of the core problems of the Views Arg Cache contributed module. The problem is simply that developers are unable to trigger a cache flush for a particular cached view if the arguments of the view are only partially known.

Additional information can be found on the project's sandbox page here: https://www.drupal.org/sandbox/amcgowanca/2296039.

Sandbox project page

Git Cloning

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/amcgowanca/2296039.git views_argument_cache_with_indexing

Comments

amcgowanca’s picture

amcgowanca CreditAttribution: amcgowanca commented
Issue summary: View changes
PA robot’s picture

PA robot CreditAttribution: PA robot commented
Status: Active » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxamcgowanca2296039git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

guilopes’s picture

guilopes CreditAttribution: guilopes commented

resolve the errors in http://pareview.sh/pareview/httpgitdrupalorgsandboxamcgowanca2296039git

amcgowanca’s picture

amcgowanca CreditAttribution: amcgowanca commented

Hi @guilopes: Thanks for the review and feedback. I have resolved almost all of the issues outlined by the PA Review script.

However, can you (or someone else) please provide insight as to how other plugin classes for Views have passed the initial review with pareview.sh when overriding class methods or following the class naming structure for views? Additionally, there are two other errors that are presented which were that the code was missing comments for the @throws tag within the .module and .rules.inc file. They do however exist.

Furthermore, there are two markdown (.md) files which have lines that exceed 80 characters. Correct me if I am wrong, but doesn't the Drupal standards recommend only 80 characters per line for text (.txt) and code files themselves and not .md?

Perhaps these are false positives?

Thanks in advance!

amcgowanca’s picture

amcgowanca CreditAttribution: amcgowanca commented
Status: Needs work » Needs review
howto’s picture

howto CreditAttribution: howto commented
Status: Needs review » Needs work

You should change your git clone command because it's a personal git clone command.

amcgowanca’s picture

amcgowanca CreditAttribution: amcgowanca commented
Issue summary: View changes
amcgowanca’s picture

amcgowanca CreditAttribution: amcgowanca commented

@howto: I have updated the Issue Summary with the a generic git clone command instead of my personal. Thanks.

howto’s picture

howto CreditAttribution: howto commented

@amcgowanca,

Do you need to change your project status to "Need Review" to allow other member review your project.

P/S. I changed your project status to "Need Work" in comment https://www.drupal.org/node/2296053#comment-8972147 (i think i should't change it.)

amcgowanca’s picture

amcgowanca CreditAttribution: amcgowanca commented
Status: Needs work » Needs review
jeffam’s picture

jeffam
Primary language English
CreditAttribution: jeffam commented

@amcgowanca,

You mention that this is derived from Views Arg Cache. Is there any reason why you couldn't contribute your improvements to that module?

If your code does everything that module does but with improvements, I could see it as v2.x.

It looks like that module isn't actively maintained. You might want to think about taking it over.

So I don't think that this should be a separate module. But if it were, I noticed that there's a license file in your repo. No need: drupal.org will add the appropriate version automatically during packaging.

amcgowanca’s picture

amcgowanca CreditAttribution: amcgowanca commented

@jeffam: Thanks for pointing out the LICENSE.md issue. That said, I think it is best to live as a separate module as the switch is too drastic between the two. This module is derived on the concept of storing arguments for caching allowing for unique view instance per argument. However, maybe it is best the community determine what is appropriate.

InviteReferrals’s picture

InviteReferrals CreditAttribution: InviteReferrals commented
Status: Needs review » Needs work
Issue tags: +PAreview: review bonus

Please Solve the automated errors first:
http://pareview.sh/pareview/httpgitdrupalorgsandboxamcgowanca2296039git

PA robot’s picture

PA robot CreditAttribution: PA robot commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.