It appears the function quiz_start_check is a more robust version of quiz_availability. I suggest consolidating them into one function and replacing the single call to quiz_start_check.

CommentFileSizeAuthor
#19 quiz_start_check_and-2281825-19.patch11.78 KBdjdevin
#17 quiz_start_check_and-2281825-17.patch11.78 KBdjdevin
#15 quiz_start_check_and-2281825-15.patch11.86 KBdjdevin
#13 quiz_start_check_and-2281825-13.patch11.39 KBdjdevin
#11 quiz_start_check_and-2281825-11.patch9.76 KBdjdevin
#9 quiz_start_check_and-2281825-9.patch9.38 KBdjdevin
#7 quiz_start_check_and-2281825-6.patch8.26 KBdjdevin
#5 quiz_start_check_and-2281825-5.patch7.24 KBdjdevin
#3 quiz_start_check_and-2281825-3.patch9.88 KBdjdevin
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

RayCascella’s picture

RayCascella
he/him
CreditAttribution: RayCascella commented
Assigned: Unassigned » RayCascella
djdevin’s picture

djdevin
Location Philadelphia
CreditAttribution: djdevin commented
Issue tags: +7.x-5.0 release blocker

This is a major annoyance.

We need to clean this up before moving to more complex entity support as well.

djdevin’s picture

djdevin
Location Philadelphia
CreditAttribution: djdevin at Cadmium commented
Status: Active » Needs review
FileSize
quiz_start_check_and-2281825-3.patch9.88 KB

Finally.

Status: Needs review » Needs work

The last submitted patch, 3: quiz_start_check_and-2281825-3.patch, failed testing.

djdevin’s picture

djdevin
Location Philadelphia
CreditAttribution: djdevin at Cadmium commented
Status: Needs work » Needs review
FileSize
quiz_start_check_and-2281825-5.patch7.24 KB

Status: Needs review » Needs work

The last submitted patch, 5: quiz_start_check_and-2281825-5.patch, failed testing.

djdevin’s picture

djdevin
Location Philadelphia
CreditAttribution: djdevin at Cadmium commented
Status: Needs work » Needs review
FileSize
quiz_start_check_and-2281825-6.patch8.26 KB

Status: Needs review » Needs work

The last submitted patch, 7: quiz_start_check_and-2281825-6.patch, failed testing.

djdevin’s picture

djdevin
Location Philadelphia
CreditAttribution: djdevin at Cadmium commented
Status: Needs work » Needs review
FileSize
quiz_start_check_and-2281825-9.patch9.38 KB

Status: Needs review » Needs work

The last submitted patch, 9: quiz_start_check_and-2281825-9.patch, failed testing.

djdevin’s picture

djdevin
Location Philadelphia
CreditAttribution: djdevin at Cadmium commented
Assigned: RayCascella » Unassigned
Status: Needs work » Needs review
FileSize
quiz_start_check_and-2281825-11.patch9.76 KB

Status: Needs review » Needs work

The last submitted patch, 11: quiz_start_check_and-2281825-11.patch, failed testing.

djdevin’s picture

djdevin
Location Philadelphia
CreditAttribution: djdevin at Cadmium commented
Status: Needs work » Needs review
FileSize
quiz_start_check_and-2281825-13.patch11.39 KB

Status: Needs review » Needs work

The last submitted patch, 13: quiz_start_check_and-2281825-13.patch, failed testing.

djdevin’s picture

djdevin
Location Philadelphia
CreditAttribution: djdevin at Cadmium commented
Status: Needs work » Needs review
FileSize
quiz_start_check_and-2281825-15.patch11.86 KB

Status: Needs review » Needs work

The last submitted patch, 15: quiz_start_check_and-2281825-15.patch, failed testing.

djdevin’s picture

djdevin
Location Philadelphia
CreditAttribution: djdevin at Cadmium commented
Status: Needs work » Needs review
FileSize
quiz_start_check_and-2281825-17.patch11.78 KB

Status: Needs review » Needs work

The last submitted patch, 17: quiz_start_check_and-2281825-17.patch, failed testing.

djdevin’s picture

djdevin
Location Philadelphia
CreditAttribution: djdevin at Cadmium commented
Status: Needs work » Needs review
FileSize
quiz_start_check_and-2281825-19.patch11.78 KB

  • djdevin committed af627dc on 7.x-5.x 
    Issue #2281825 by djdevin: quiz_start_check and quiz_availability are...
djdevin’s picture

djdevin
Location Philadelphia
CreditAttribution: djdevin at Cadmium commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.