[D7] Opigno LMS Tour module

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Seems ok to me. Tested and working
Best regards
James Aparicio

@Jamesap, the person making the project application adds "PAReview: review bonus" when they have completed reviews of other projects. See https://drupal.org/node/1975228

@axelm, can't this just be a submodule in https://drupal.org/project/opigno_lms? Does this need to be a standalone module that would require you to go through the application process? It seems like this would be really beneficial to have in that project from the get-go. Also, see comment #1. The reviewers are backed up right now, and review-bonus applications are taking higher priority right now.

Seems ok to me as well

Hi wadmiraal,

I saw you had a few modules under your name. Aren't you already a git vetted user if you're able to already make projects? If so, why are you submitting this module?

If not, I have applied the Code too short tag for you, as this module won't be able to make you a git vetted user. I would suggest having your colleague make the module if you aren't able to.

Could you clarify as to whether you're able to post projects? If so, kindly also clarify the purpose of submitting this module to the Project Application issue queue? (ie, was it an error?).

Code too short

This project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed. However, we can promote this single project manually to a full project for you.

Automated Review

The pareview.sh reports 1 error.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

No: causes module duplication and/or fragmentation. As previously stated in #3, i think this could be a opigno_lms submodule too.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

No: Does not follow the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

No: Does not follow the guidelines for project length and complexity. The number of lines of code is greater than the required minimum, but this does not happen with the number of functions. The module has only 1 function. This was previoulsy stated in #6

Secure code

Yes: Meets the security requirements. But it includes HTML tags in strings which are passed through the t() function, making that strings hard to be translated.

Coding style & Drupal API usage

Yes: meets the coding style & Drupal API usage.

Conclusion

I think this module could prefectly be a opigno_lms submodule (i don't think this will be a heavy module causing the opigno_lms to be a heavier module, see #3). If anyone finds a good reason for this module to be a full module, then the issues reported in #6 should be cleared up before any further analysis of this module.

fixing tags.

Manual Review

Just adding my voice to the "should probably be a submodule" chorus.

The heaviest module in Drupal history isn't going to weigh down a system if it hasn't ever been enabled!

module.info File

Your module.info file has two lines defining the core version... one was apparently added by Drush. There should just be one.

Thanks for your contribution, axelm!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.