[D7] Apachesolr repeating dates

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Please follow this template for the readme file:
https://drupal.org/node/2181737

apachesolr_repeating_dates.db.inc

/**
* Retrieve all fields stored in the module table.

I don't think it's about the "module" table. Please fix the comments in the *.db file.

function _apachesolr_repeating_dates_prepare_field - is declared in *.module file but used only in *.db. I think you should move it to *.db file.

$entity_fields = field_info_instances('node', $entity->type);

If it's applicable to nodes only, please make a not about that in description and readme.

Some more questions:
1. Don't we need to implement some actions on module uninstall?
2. It would be nice to have some real-life use-cases for the module on the project page.
3. And also pay attention that in the last commit you deleted a function that is in use in the *.install file:

$fields = apachesolr_repeating_dates_get_field_instances();

Best regards,
Smartling

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxls2062268095git

I'm a robot and this is an automated message from Project Applications Scraper.

@ls206, thanks for your contribution.

Manual Reviews:
1. You are adding file through following code but you can also use module_load_include function for this.

require_once 'includes/apachesolr_repeating_dates.db.inc';

It should be something like this:

module_load_include('inc', 'apachesolr_repeating_dates', 'includes/apachesolr_repeating_dates.db');

2. Your project page contains few information, can you extend this little bit more it would be more useful :)
3. Also add hook_help() in your module file.

I would manually test your module once I'll get some time in next few days and come back to you :)

Thanks Again!

Review of the 7.x-1.x branch (commit 62ab877):

• No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

I'm not that familiar with Date repeat and Apachesolr module but the code looks RTBC to me after a manual review.

Assigning to stBorchert as he might have time to take a final look at this.

Thanks for your contribution, Louis!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

One minor note to the module itself: it would be great if you could turn the feature on and off per index so in one index the repeated dates are split into several search results and in another index the document is indexed as one.