When using the form wizard and using the form callbacks as suggested in the help ($hook_$step_form) a notice occurs:

[Notice] Undefined index: form id [/sites/all/modules/contrib/ctools/includes/wizard.inc:510]

CommentFileSizeAuthor
#1 2265319-1-ctools-wizard_default_form_id_notice.patch544 bytespfrenssen

Comments

pfrenssen’s picture

pfrenssen
Location Sofia
commented
Status: Active » Needs review
StatusFileSize
new 2265319-1-ctools-wizard_default_form_id_notice.patch544 bytes

Simple fix.

DamienMcKenna queued 1: 2265319-1-ctools-wizard_default_form_id_notice.patch for re-testing.

chris matthews’s picture

chris matthews commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

The 5 year old initial patch to wizard.inc does not apply to the latest 7.x-1.x-dev and needs a reroll.

Checking patch includes/wizard.inc...
error: while searching for:
  $form_info = $form_info + $defaults;
  // set form callbacks if they aren't defined
  foreach ($form_info['forms'] as $step => $params) {
    if (!$params['form id']) {
       $form_callback = $hook . '_' . $step . '_form';
       $form_info['forms'][$step]['form id'] = $form_callback;
    }

error: patch failed: includes/wizard.inc:507
error: includes/wizard.inc: patch does not apply

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs work » Fixed
Issue tags: -Needs reroll

I've rerolled and committed this, thanks @pfrenssen and @Chris2

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Parent issue: » #2984057: Plan for CTools 7.x-1.15 release

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.