Port to 6.x

Yes, this will be ported, but not until at least these issues are completed:
Bugs:
#219678: Omit 'Date/Time: [Untimed]:' in email notification to event owner
#219680: Inadvertent dislosure of email address via signup

New features:
#86462: add backend support for cck date fields
#45419: using signup to track who can not attend, maybes, etc

And ideally this, too:
#29568: Flexible number and type of fields

So, if anyone's interested in the 6.x port, please work on any/all of those issues for now (especially the first 3). Thanks.

I wish I were able to help, but I don't have the expertise / understanding. Nonetheless, I wanted to ask if any progress is being made, as this port is vital to me. Thanks.

I keep my issues very well updated. ;) Furthermore, thanks to the slick input filter we're using for referring to issues, the things listed in my comment #1 that are blocking progress here will automatically cross themselves out when those issues are marked fixed.

If you can't help with expertise or understanding, how about sponsorship?

subscribing

Subscribing

subscribing

keep me up to date

...

@dww - Like Ian Douglas above, I don't have the expertise (not near enough anyway) to start a port or fix these issues, but I would be more than happy to help bug test and help in any area needed. Also, I'm curious, what would sponsorship entail? I don't have much to contribute, and would be using this port for a hobby site, but eventually probably for more.

Maybe, also, I'm just not totally confident in my coding abilities. Perhaps I'll take a stab at the code too. :)

Like Jacobroufa above, I can't code (it's scary and bug filled when I try), but I would be more than happy to assist with beta testing on one of my sites when this is ready for testing.

dww, is there any projected time frame on when/if you will complete these issues and get the port to 6.0 completed?

Could the process by speeded up by sponsorship?

"if": yes.

"when": it depends.

"speeded up by sponsorhsip?": definitely. Numerous people have contacted me inquiring about sponsorship, I responded to each of them, and not a single person replied. :( I'm contemplating announcing a "signup sprint", putting up a chipin page somewhere, and trying to see if everyone can pool their sponsorship offers into enough money to make it happen.

dww, I'd be willing to donate some programming time to make this port happen. I recently added a patch for this issue: #86462: add backend support for cck date fields (which I need to update to add support to date2.0), which also seems to fix this issue: #219678: Omit 'Date/Time: [Untimed]:' in email notification to event owner. Which leaves a couple tasks undone (the two listed still need testing). Let me know what is a priority and hasn't been done yet. Is this issue still need? #219680: Inadvertent dislosure of email address via signup

dww....I was one of those that contacted you regarding sponsorship and you're correct that it just wasn't do-able to fund the entire thing in my budget (I have to be able to pass the full cost off to a client project). While I can't fund the whole thing, I'd be happy to throw in a good chunk if you could get others on board as well. A chip in would be welcome...

Anyone else willing to sponsor a decent size chunk on this?

Subscribing.

subscribing - donating as well: where to?

subscribing

I need this module in 6.x for a site that I'm developing, so I've done a port of this. I am also generally of the belief that too many modules have been held up in 5.x, so I'll post it here. Right now I have a version that works with both event and views disabled (it might not compile if they are enabled!), and in the next few days I want to work with the .inc files as well and come up with a complete working version. This is build off the 5.x-2.4.
I hope developers will build on this so we can move to an official port. If you ask me, there's no reason why there shouldn't be a 6.x branch for any module as soon as there is someone to write some kind of code for it. Patches that involve a few lines of code shouldn't delay a port that takes weeks to complete and test (they can always be applied later). I hope this (and the update I will post in the next days) will make the 6.x version come sooner.

Here is a version that I invite everyone to test. It works great on my site, and hopefully it will work on yours too. The module should run exactly like 5.x-2.4. I have not changed or altered functionality in any way other than to make it work for 6.x.

Here are a few notes about this version:
- I have not ported signup_views.inc (someone that is familiar with Views 2.0 will have to rewrite that and uncomment the require_once statement as such)
- in signup.install, I have not ported the schema updates. there is just the normal install and uninstall, so 5.x users upgrading will have to have the latest schema before upgrading.
- signup_event_5.x-1.inc has been removed, and signup_event_5.x-2.inc has been renamed to signup_event_5.2.inc. The event.module-6.x has the 5.2 version of event API. I'm using it and it works fine so far.
- Other comments related to the port can be found by searching for '//D6'
- changelog.txt, install.txt, readme.txt and upgrade.txt are unchanged (they will need to be updated for the 6.x release)
- the translations folder will need to be redone to cover the new strings and line numbers (there are fewer t() calls due to 6.x menu system and watchdog changes)

rares,

Thanks for your work on this port. I too was working on a port to 6.x in my spare time, though focusing mainly on upgrading to views 2.x and using the Date module w/ 6.x (#86462: add backend support for cck date fields). I'll start testing your upgrade, and integrating the new views api into the module. I still haven't heard back from dww if he wants to use my Date patch in either 5 or 6, so I'll hold off integrating that as well.

it's great that you've done some work on the views side of things (I have no experience with that whatsoever), so with that (and word from a few other people that the port I made works) we'll have a version that can be made into a 6.x-dev branch and posted on the project page.
Can someone give some advice on what approach is best for the .install file and for defining database schemas from the point of view of 5.x users migrating to 6.x? For instance, what happens to a user that runs 5.x and has a schema version 5200 when he upgrades drupal and this module to 6.x? what needs to be included in the install file to tell Drupal that this is still 5200? (installing the module on 6.x now gives schema 0). I assume it's reasonable to request that users upgrade to the latest 5.x before moving to the 6.x, isn't it (so that we don't have to write all the hook_update_N)...

@rares

I was wondering the same thing myself. Since there doesn't appear to be a standard practice defined yet, Do As Core Does . All of the core modules that have install/update profiles start with 6000 and don't include any of the 5xxx update functions. I think it's absolutely reasonable to ask users to upgrade their 5.x modules before upgrading their site to 6.x. Looking at the CCK and Views modules, they do the same things (starting with update_6000, not including 5.x updates). Since we're actually not adding any new features, and the database tables are the same as the latest version, I think we only need the base install functions. Attached is the stripped down signup.install file, using the new db schema.

Subscribing. Very interested in chipin sponsorship, if this version will be compatible with calendar_views & CCK event type.

dww, rares, duelli - is chipin available? If so, please direct me where I can contribute.

thx
kelly

Testing the signup 6.x dev

Got this error when I got to site config / signup

user warning: Table 'kristina_drupal63.signup' doesn't exist query: SELECT * FROM signup WHERE nid = 0 in /home/kristina/public_html/dev/sites/default/modules/signup/signup.module on line 1736.

@rares: Thanks for doing some work on this. However, I wish you had followed my advice from comment #1 and worked on the other issues first.

"If you ask me, there's no reason why there shouldn't be a 6.x branch for any module as soon as there is someone to write some kind of code for it. Patches that involve a few lines of code shouldn't delay a port that takes weeks to complete and test (they can always be applied later)."

Yes, but these aren't patches that involves a few lines of code. The CCK backend integration is a huge patch that touches lots of code. Ditto the changes for tracking yes/no/maybe, and finally killing the insane theme-based method for customizing the signup form. What you've done here is just make more work for me, and the folks working on these other issues, since your monolithic .zip version is much harder to work with. If I committed it to a 6.x-1.x-dev branch, it'd just ensure patch/merge conflicts for the other issues, etc. There's a very good reason I postponed this issue in the first place: fixing those other things are going to require fairly major restructuring of the code, and porting to 6.x before all that happens makes more work for everyone.

Finally, a .zip file of all the changed files makes your efforts much harder for anyone else to review what you've actually changed. I really don't have the time or energy to download your thing, unpack it into one directory, run diff manually against the code in CVS, and generate a patch file that I can then review. :(

Anyway, I don't want to give you the impression that I resent you've spent time on this, but I'm just being honest that it's probably not going to speed up the creation of a 6.x-1.0 release as much as working on the other issues I mention in #1 would.

Thanks/sorry,
-Derek

Derek,

Thanks for the update. It's too bad all of this work was for naught, though I understand the need to develop and integrate the patches listed in #1. I went ahead and developed the Views 2.0 integration for Signup, mostly because I was interested in how the internals of Views works, and doing a port was a good way for me to do that. Let me know if you would like those files and the best way to post them. I could post a patch, though they are in two separate, new files now (signup.views.inc and signup.views_default.inc) so I could just post those as well.

I know that Signup isn't you're top priority, especially with all the work you're doing over on Project. I'd be interested in helping out in allowing custom signup fields for the signup form. There was talk of using forms.module, though it looks like that module is no longer supported. I guess I'll continue the discussion over at the project page (#29568: Flexible number and type of fields).

Thanks,
Jon

- Yes, feel free to post the views2 versions of the signup views support as raw files attached to a comment here. That'd be a help, certainly.

- Yeah, let's talk about custom fields over at #29568. Bummer that forms.module is no longer supported. Maybe there's another way. There's always the signup-as-a-CCK-node approach I outlined here: http://groups.drupal.org/node/3430

subscribe.

Here's the files for views2. Since views include files are now included automatically by views, all views related code can be removed from signup.module (except for the conditional include of signup_no_views.inc).

Subscribing

Hi,
I've consolidated the work I did on signup.module and duellj's work on views and the .install file into these files. The archive has the module directory for 6.x and should install, uninstall and work independently as well as together with events and views. Nevertheless, treat this as an experimental version. Porting the module and forms-related stuff has definitely been a lot of work, and I trust that this patch will be a reference when the maintainer decides to port the next stable version of 5.x.
There is also a patch file for signup.install, signup.module and signup_no_views.inc that can be applied to the 5.2 version of Signup. However, aside from applying that patch you would also need to copy the three new files from the archive: signup.views.inc, signup.views_default.inc and signup_event_5.2.inc (a mere rename of the former signup_event_5.x-2.inc).
@Passionate_less, using this version should get you rid of the error that you were reporting (caused by lack of database schema in previous patch). You might have to uninstall that version first in order to get this hook_install() to run.
Rareş (read Rar-esh)

rares, thank you for all your work on this.

The zip file you attached does not contain the entire module directory, as you state in your comment, but only the patch file.

Gustav, thanks for pointing that out!

Rares, I had a chance to give that last attachment a shot. I believe that the signup.install file had most of the database schema creation code accidentally commented out. I manually created the tables via phpMyAdmin and got the module up and running. So far so good, signups are configurable, and I can assign them to all my content types!

The only problem is that upon signing up i get the following error (screenshot attached as well):

warning: preg_match() expects parameter 2 to be string, array given in <site directory>\includes\unicode.inc on line 280.

Now, this error does appear after I asked my webhost to increase my php_upload limit in my php.ini file, so I wonder if that might have something to do with it. Anyway, though you might like to take a look at that error.

Note to anyone interested in seeing this done soon: I started a ChipIn to raise money to fund porting, testing, and releasing a 6.x-1.0 version, along with all the changes to the codebase that need to happen before any of that can be done cleanly. I placed a ChipIn widget on the signup project page so donate there if you can. Thanks.

See also #293005: Create a signup 5.x-2.5 release for a list of issues to be resolved before the 5.x-2.5 release. That's the next concrete dependency towards getting started for real on D6 porting. Cheers.

Hey Derek - just contributed $50 to this effort. Thanks for your work on it.

But since I needed it today - installed @rares updates and can also confirm they are working - if the real 6.x release breaks what he has done... I can't say you didn't warn me :). I am working on a simple site - no views or CCK date or event integration needed. This thread was reminding me of an issue on Ecommerce this year - I think still in an alpha stage, about 10 months later on v4 - basically it forces people including me to find alternative solutions (like magento, which is what happened). What I wish they had done on Ec, and maybe you'll consider, is splitting this into a "basic" (no views no cck no event support - just the signup form attached to nodes) and "full-tilt" release (all the bells and whistles) - keep the basic one simple and in-step with Drupal releases, and take your time on the full-tilt version - or get people that need those features to fund them.

Anyway, thanks for being a maintainer on this, and your work with Drupal.

I've been testing rares' version from #33. If you're interested in feedback and a couple of bugs I've come across let me know, otherwise I won't clutter up this issue any further.

awolfey, we are also working with rares' version (which currently appears to be the best option in the absence of an official version) and would therefore be very interested in your bug reports and patches.

I haven't had a chance to fully test this, and not on a fresh install either, but...

There seem to be some problems: I see the signups and and signup broadcast tabs on nodes that are not signup enabled.

When viewing Signup Administration, I get this error, looks like 1 time for each signup:

warning: Missing argument 2 for signup_admin_node_form(), called in /home/bigcwol3/public_html/d6test/sites/all/modules/signup/signup.module on line 1014 and defined in /home/bigcwol3/public_html/d6test/sites/all/modules/signup/signup.module on line 1531.

in Administration, Status is showing as Closed for open signups, probably related to above.

I'll let you know what else I find out.

Please don't use this issue as a catch-all bug tracking system for the various initial porting efforts posted here. There's no real version of signup available for D6 yet, but I hope to be able to change that fact in the near future. Spending time reading replies in here about a patch that I don't support will only slow down an official 6.x-1.0 release. Thanks.

subscribing...

subscribing

Anyone needing signup to a node today, might have a look at webform http://drupal.org/project/webform

Doesn't support signing up to any node type - but for my purpose, just renamed the webform node type to "Classes", and put the page content at the top. It has the ability to limit access by role - so can force a user to register (and collect profile fields), and then drop them back to the webform page to collect whatever signup fields you feel like creating.

-G

Hey Guys (and gals),
Thanks for all the community-work that has gone into this project.

I'm curious if this module will have the ability to "hook" to any of the ecommerce packages? I know that's not the main function of this module, but it would be helpful if the ability was built into the original release, so that a user can first sign up, then pay for the event.

thx again,
kwg

@kwgossett: Please don't hijack issues (especially important ones like this that a lot of people are interested in) with off-topic questions. If you searched the issue queues a bit, or read the project page for signup, you'd get the answer to your question.

Is there an updated full zip of the module I can test?

I'm patch dumb but if someone gives me a zip of the up to date supported dev version I'll be happy to install and test it. :)

This issue will move from "postponed" to "patch (code needs review)" and there will be a 6.x-1.x-dev release that you can download when it's ready for other testing. For now, it's still postponed because there are some bugs and pending issues that need to be resolved before 5.x-2.5 can be released, which is the next step before real porting to D6 begins.

I'm happy to report that the chipin fundraising drive has been mostly successful, and I'll be able to work on this now instead of looking for other paid work, so there will soon be progress.

Cheers,
-Derek

That's Great News!

Very much looking forward to the D6 release. Good luck with the port.

Good to hear there's action going forward with this! I've been traveling for the past month, so I haven't had much of a chance to look at the issues we were working on, but let me know if you need any help with patches and testing.

Thanks!
--Jon

subscribing

i became this error when i use the D6 Version #33

user warning: Table 'usr_web3_1.signup' doesn't exist query: SELECT * FROM signup WHERE nid = 70 in /var/www/web3/html/sites/all/modules/signup/signup.module on line 626.
user warning: Table 'usr_web3_1.signup' doesn't exist query: SELECT * FROM signup WHERE nid = 18 in /var/www/web3/html/sites/all/modules/signup/signup.module on line 626.
user warning: Table 'usr_web3_1.signup' doesn't exist query: SELECT * FROM signup WHERE nid = 14 in /var/www/web3/html/sites/all/modules/signup/signup.module on line 626.

and when i change the settings, it comes this error:

user warning: Table 'usr_web3_1.signup' doesn't exist query: SELECT * FROM signup WHERE nid = 0 in /var/www/web3/html/sites/all/modules/signup/signup.module on line 1729.
user warning: Table 'usr_web3_1.signup' doesn't exist query: SELECT COUNT(*) FROM signup WHERE nid = 0 in /var/www/web3/html/sites/all/modules/signup/signup.module on line 1260.
user warning: Table 'usr_web3_1.signup' doesn't exist query: DELETE FROM signup WHERE nid = 0 in /var/www/web3/html/sites/all/modules/signup/signup.module on line 1273.
user warning: Table 'usr_web3_1.signup' doesn't exist query: INSERT INTO signup (nid, forwarding_email, send_confirmation, confirmation_email, send_reminder, reminder_days_before, reminder_email, close_in_advance_time, close_signup_limit, status) VALUES (0, '', 1, 'Enter your default confirmation email message here', 1, 0, 'Enter your default reminder email message here', 0, 0, 1) in /var/www/web3/html/sites/all/modules/signup/signup.install on line 139.
user warning: Table 'usr_web3_1.signup' doesn't exist query: SELECT * FROM signup WHERE nid = 0 in /var/www/web3/html/sites/all/modules/signup/signup.module on line 1729.
user warning: Table 'usr_web3_1.signup' doesn't exist query: SELECT * FROM signup WHERE nid = 18 in /var/www/web3/html/sites/all/modules/signup/signup.module on line 626.
user warning: Table 'usr_web3_1.signup' doesn't exist query: SELECT * FROM signup WHERE nid = 14 in /var/www/web3/html/sites/all/modules/signup/signup.module on line 626.

the changes were not stored

@Babalu: If you're going to "subscribe", please read the issue. Oh yeah, all those "subscribe" posts make that harder, don't they? ;) Anyway, see comment #41.

(subscribe) :)

subscribing

subscribing

Hi Rares,
#33 doesn't seems to install the tables here, Drupal 6.6...

fabiano

#45419: using signup to track who can not attend, maybes, etc

Do we really need this before D6 release?

no, first a working D6 release

A) No, not all of the features on my wish-list made the cut before my own self-imposed feature freeze.

B) I've done a *ton* of prep work on the code base, and created a DRUPAL-5--2 branch so that HEAD can be for D6 porting.

C) There are a few more things I'd like to fix, and lots of testing that I'd love to see done, before I make the 5.x-2.6 release. Please join us at #328756: Create a signup 5.x-2.6 release to help out -- there are two patches that need review/testing/comments before I ship the next release.

D) I've started the actual porting. I've looked at the patches in here, and besides the fact that none of them apply at all (as expected), none of them actually work, either. ;) There are a few bits and pieces I can reuse, but mostly, I've just started over from scratch using deadwood and my own abilities. This is what prompted #328822: Remove global $form_values from hook_nodeapi() and otherwise clean up the logic for example. I haven't yet gotten to the point that I wanted to start testing the views2 stuff from duellj in #29, but that much looks promising at first glance.

E) I'm actively working on the port now. If people want to help or see it come faster, you can:
- Review the other patches that I post or at least comment on the issues I create.
- Help test the HEAD branch and/or 6.x-1.x-dev tarball once I've committed an initial D6 port to CVS and created a release node for it. I'll definitely comment here when that happens.

F) More comments to this issue saying "I tried the patch from #N, and it doesn't work" where N < 61 are not helpful. ;) I know they don't work. ;)

Subscribing.

Great work dww - looking forward to testing :)

I've committed the initial D6 port to HEAD and I created a 6.x-1.x-dev release.

Known bugs:
#330838: Validation of signup form broken in D6
#330839: Validation of username field broken when admins signup other users in D6
#330840: Sending yourself a copy of a signup broadcast is broken in D6

Completely untested:
#330820: Test/fix Views2 integration
#330821: Test/fix CCK date 6.x-2.* integration
#330822: Test/fix Event 6.x-2.* integration
#330823: Test/fix token integration
#330824: Test/fix panels integration

Also, it'd be nice to do these before the official 6.x-1.0 release, though they're not required:
#330828: Split module code into separate .inc files for D6 menu API
#330829: Split theme functions out into .inc files.

Anyone who wants to help test or otherwise contribute to the port should move to any of those issues they're interested in. I'm marking this one postponed until all of the above (and any other new issues people find) are resolved. At that point, I'll make an official release, and mark this fixed.

Hi dww, I started testing the 6.x-1.x-dev release this morning. Anything relating to the issue above I'll add to those issues separately.

Here's something I found (doesn't seem to match to the known issues above):

Settings screen is blank: found error in reports
* the Signup settings admin screen at /admin/settings/signup is blank white.
* Checked reports, and found this error:

Type	php
Date	Thursday, November 6, 2008 - 10:56
User	admin
Location	http://localhost:8888/test/admin/settings/signup
Referrer	http://localhost:8888/test/admin/by-module
Message	Table 'test.view_view' doesn't exist query: SELECT name, description, page, block FROM view_view in /Applications/MAMP/htdocs/test/sites/all/modules/signup/signup.module on line 1745.

Following email link also leads to this error on profile
After signing up, I get an email with a link to my account. Heres the error message:
user warning: Table 'test.view_view' doesn't exist query: SELECT name, description, page, block FROM view_view in /Applications/MAMP/htdocs/test/sites/all/modules/signup/signup.module on line 1745.

@scottrigby: That error is definitely from #330820: Test/fix Views2 integration. Either turn off views.module, or try the latest patch from that issue.

@dww - the patch clears this error up. Thanks :)
will keep views integration feedback in that issue.

subscribing...

All the known issues are now committed. Everyone is hereby invited to test out 6.x-1.0-rc1. If you find any problems, please search the signup queue and if there's not already a bug report about what you found, create a new issue. Thanks.

Great work dww :)

Updated the signup module, and ran the DB update.

Now I'm getting this error:

Fatal error: Cannot redeclare theme_signup_user_form() (previously declared in /home/qwo/public_dev/sites/default/modules/signup/theme/signup.theme:50) in /home/qwo/public_dev/sites/default/modules/signup/theme/signup_form.inc on line 71

@Passionate_Lass: You did something wrong at the "Updated the signup module" step. Neither the DRUPAL-6--1-0-RC1 tag, the HEAD branch, nor the http://ftp.drupal.org/files/projects/signup-6.x-1.0-rc1.tar.gz tarball contain the theme/signup.theme file. You must have just copied the new files on top of the old files or something. If you correctly upgrade to the latest version, you won't have this problem.