[D7] Pathauto i18n

.
1. Function names should not be in continuous tense - pathauto_i18n_processing_entity()(pathauto_i18n.module:11), also this is a good style to include documentation to your code that could be used outside of your module
2. Why do you skipping only node entities if language is undefined? - pathauto_i18n.module:38
3. Why function is called pathauto_i18n_field_configuration() when is basically a form builder? Something like pathauto_i18n_configuration_form() would be more appropriate - pathauto_i18n.module:56
4. It's better to use condition() method instead of where() for simple IN conditions(condition('entity_id', $ids)) - pathauto_i18n.module:101
5. Wrong function name, implementation for hook_node_load() in pathauto_i18n_node module should be called pathauto_i18n_node_node_load() - modules/pathauto_i18n_node/pathauto_i18n_node.module, check all node hooks
6. pathauto_i18n should have taxonomy as dependency
7. Wrong hook implementation function name - modules/pathauto_i18n_user/pathauto_i18n_user.module

Don't forget to review other requests and participate in Review bonus programm.

1) pathauto_i18n schema should have complex unique key: entity_id and entity_type, as you use single table for all entity types
2) If you don't need second variable here list($entity_id, $entity_vid, $bundle) - just skip it list($entity_id, , $bundle)
3) Add additional comments to pathauto_i18n_field_configuration() to avoid misunderstanding like @RoSk0 got, at least add some @see references
4) Can you add some comments for // Remove current user language.
$account->language = LANGUAGE_NONE; because it looks bad :)

Just to clarify, although Pathauto already supports path patterns for multilingual nodes, it only works for fully multilingual nodes- it doesn't work for nodes with only partial translations, or for other types of entities (according to sanchiz). This is the gap that this module fills. It would be good to include this information in the project description.

The code looks pretty good. I would write a unique @file block for each of the modules better describing their purpose. For instance, it seems like the main module doesn't actually do anything on its own, so the @file descriptor should say so- i.e. "Provides common functions and callbacks for pathauto_i18n submodules. Does not contain any hooks or provide functionality on its own."

Cool beans. I don't know if it's my job to mark this RTBC or not, but there you go...

Review of the 7.x-1.x branch:

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  
  FILE: /home/klausi/pareview_temp/pathauto_i18n.module
  --------------------------------------------------------------------------------
  FOUND 6 ERRORS AFFECTING 6 LINES
  --------------------------------------------------------------------------------
    5 | ERROR | Doc comment short description must be on a single line, further
      |       | text should be a separate paragraph
   24 | ERROR | There must be exactly one blank line before the tags in a doc
      |       | comment
   61 | ERROR | Paramater tags must be defined first in a doc commment
   64 | ERROR | Paramater tags must be grouped together in a doc commment
   67 | ERROR | Paramater tags must be grouped together in a doc commment
   70 | ERROR | Type hint "array" missing for $form
  --------------------------------------------------------------------------------
  
  Time: 234ms; Memory: 6.5Mb
  

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

But otherwise looks good to me, so ...

Thanks for your contribution, sanchiz!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.