Problem/Motivation
Theme screenshot alt-text and theme descriptions need improved text to provide more detailed explanations of the features supported by the theme (especially for non-sighted admins). Review and update as needed the text for all themes.
Every screen-shot has the alt text "Screen-shot for [theme-name] theme".
Originally the proposal included updating tags as well. However, tags were removed in #2471619: Remove tags from all core theme.info.yml files.
The description and alt text on Drupal 9.4.x.
Bartik
description: 'A flexible, recolorable theme with many regions and a responsive, mobile-first layout.'
Seven was fixed in [#2193691
description: 'The default administration theme for Drupal 8 was designed with clean lines, simple blocks, and sans-serif font to emphasize the tools and tasks at hand.'
alt text: 'Default administration theme for Drupal 8 with simple blocks and clean lines.'
Claro
description: 'A clean, accessible, and powerful Drupal administration theme.'
alt text: 'Screenshot of Claro, Drupal administration theme.'
Olivero
description: 'A clean, accessible, and flexible Drupal front-end theme.'
alt text: 'Screenshot of Olivero, Drupal front-end theme.'
Stark
description: 'An intentionally plain theme with no styling to demonstrate default Drupal’s HTML and CSS. Learn how to build a custom theme from Stark in the Theming Guide.'
Steps to reproduce
Proposed resolution
Bartik from #922696: Follow-up: New methods, standards for describing core themes on themes admin page (was Theme screenshots do not have adequate alt text...)
description:
- Responsive mobile first layout with multiple regions for layout flexibility. Customisable color schemes.
- Clean typography with serif fonts in a mobile-first layout. The color scheme can be customized. Multiple regions for content provide a lot of layout flexibility.
alt text: TBD
Seven was fixed in #2193691: New methods, standards for describing Seven themes admin page
description: 'The default administration theme for Drupal 8 was designed with clean lines, simple blocks, and sans-serif font to emphasize the tools and tasks at hand.'
alt text: 'Default administration theme for Drupal 8 with simple blocks and clean lines.'
Claro
description: TBD
alt text: TBD
Olivero
description: TBD
alt text: TBD
Stark
description: TBD
alt text: TBD
Remaining tasks
Suggest new wording/Write a patch.
Add screenshots to show visual changes the patch makes.
Review the patch.
User interface changes
Adds more detailed explanations of the features supported by the theme.
API changes
N/A
Data model changes
N/A
Release notes snippet
Original report by Everett Zufelt
On /admin/appearance there is a list of all Core themes. Each theme provides a screen-shot, a name, and a description.
1. Every screen-shot has the alt text "Screen-shot for [theme-name] theme".
2. The theme descriptions are inconsistent in how they describe the themes.
3. None of the theme descriptions are close to being sufficient to inform a blind administrator about how the theme looks or how its regions are laid out.
Comment | File | Size | Author |
---|---|---|---|
#51 | 2193693-51.patch | 554 bytes | ashishdalvi |
#44 | 2193693-41.patch | 558 bytes | pradeep22saini |
#38 | interdiff.txt | 602 bytes | gaurav.pahuja |
#38 | 2193693-38.patch | 554 bytes | gaurav.pahuja |
#32 | test-branch-bartik.patch | 560 bytes | galactus86 |
Comments
Comment #1
peterx CreditAttribution: peterx commentedI know of only one blind site admin and, unfortunately, he does not use Drupal. Do we have someone to test this change?
We could find out what interests people by looking at searches on https://www.drupal.org/project/project_theme.
We then have to weed out the subjective things because everyone labels their themes as powerful, simple.
Responsive is the first thing I would add.
Does it require SASS or composer or anything external? That is something to avoid for many sites.
You can count the number of regions as an indicator of flexibility.
People seem to like grid systems then argue over the specific grid. 960 is probably the most useful option.
Wireframes?
What would be useful and could be checked objectively?
Comment #2
Jeff Burnz CreditAttribution: Jeff Burnz commentedthe alt text is probably the most important thing. Personally I want parity with modules, so we can group themes, set dependancies etc, such as require by, requires etc.
Comment #3
peterx CreditAttribution: peterx commentedClassy has the following description:
description: 'A base theme with sensible default CSS classes added. Learn how to use Classy as a base theme in the Drupal 8 Theming Guide.'
I suggest we reuse the module config link idea for documentation. Make a documentation page a standard requirement for core themes and modules.
For things like SASS:
SASS could then be selectable in the list.
Comment #4
Jeff Burnz CreditAttribution: Jeff Burnz commented@perterx, yeah, that would totally awesome, it's horrible how we have to write stuff like this into the description.
Comment #5
emma.mariaComment #6
emma.mariaComment #7
alvar0hurtad0IMHO this is the patch
Comment #8
emma.mariaUpdated the issue summary to make it easier to follow.
Everything was outlined in detail in #922696: Follow-up: New methods, standards for describing core themes on themes admin page (was Theme screenshots do not have adequate alt text...).
This is just the specific follow up ticket for the work for Bartik.
Comment #9
emma.mariaComment #10
emma.mariaPatch review of #7
- The screenshot text is correct.
- The new description text is taken from @yoroy's take on the new text which I approve of - see https://www.drupal.org/node/922696#comment-7963475.
My only query is where are the tags used? And what tags do we have to choose from?
I looked at Seven's tags and also asked @lewisnyman and we can't find where these tags are used. I can see the use of them for contrib but are they used/needed for default themes that are not listed on drupal.org in the same way?
Comment #11
alvar0hurtad0About the tags, the patch uses: responsive, fixed width, 3 column, customizable color.
Seven has: multi-column, fluid, responsive, sans-serif, accessible
I can change the tags, what do you think?
Comment #12
Jeff Burnz CreditAttribution: Jeff Burnz commentedLike emma I don't see the point of tags in core themes, they serve no purpose.
FWIW though Bartik is not a fixed width design in the classic sense of a fixed width design.
Other than that I never quite understood what "clean typography" is, I think a better description is that it's minimalist.
Comment #13
Jeff Burnz CreditAttribution: Jeff Burnz commentedIs there actually an issue for using this alt text? If there is can someone please add it as the parent or related issue, otherwise I think we really need to be doing that first.
Comment #14
emma.mariaSo I think for this issue we should focus on just the description and the alt text.
We have agreed above that tags might be pointless for core themes, we can spin this discussion off into a separate issue to discuss.
Issue for this #2471619: Remove tags from all core theme.info.yml files.
Alt text concerns
The issue summary stated that the alt text should be as follows ....
However in the Seven version of this issue #2193691: New methods, standards for describing Seven themes admin page which had the exact same guidelines, they decided and committed this much more descriptive text as follows...
+alt text: 'Default administration theme for Drupal 8 with simple blocks and clean lines.'
Work to be carried out for this issue:
1. Remove the tags from the patch.
2. Decide if we should change to a more descriptive alt text for Bartik or raise an issue for Seven to tone theirs down.
3. If we keep the current alt text please can we correct "screen-shot" to "screenshot".
Comment #15
lauriiiI don't see what is the reason for more descriptive alt text. It seems to contain everything that is also in the description?
Comment #16
jeanfei CreditAttribution: jeanfei commentedI've removed the tags line and correct 'Screen-shot' to 'Screenshot'. I didn't change the alt text.
Comment #17
jeanfei CreditAttribution: jeanfei commentedComment #18
yannickooI'm a little bit confused with this new
alt
property, +1 for lauriii's comment. Is sth. like "Screenshot for x theme" would be fine for all themes, wouldn't it?Comment #19
star-szrAlso that 'alt text' key is not used anywhere that I can see. Using that if present would have to be a separate issue if it's desired.
The alt text is currently auto-generated and is already "Screenshot for Bartik theme" - only difference is there is no period.
Comment #20
yannickooComment #21
emma.mariaComment #22
Bojhan CreditAttribution: Bojhan as a volunteer commentedUgh, this sounds horrible. I have no idea what half of this really means "clean typography" "mobile-first? - not true". etc.
Isn't the fact that this shows the flexibility of Drupal the reason, we want people to see this? Design wise there are good attributes, but I don't think typography plays such a central role.
Comment #23
yoroy CreditAttribution: yoroy commentedI agree, what was I thinking! :-)
Is "Provides multiple regions for layout flexibility. The color scheme can be customized." better?
Comment #24
Bojhan CreditAttribution: Bojhan as a volunteer commented@Roy Going to art school, this should be our speciality. I do really like when it comes to the aesthetic talking about the intend.
"Default theme with multiple regions for content that provide layout flexibility. Using.... "
Comment #25
emma.mariaComment #26
Bojhan CreditAttribution: Bojhan as a volunteer commentedAnyone can pick this up, doesn't specifically needs ux review.
Comment #28
mgiffordDoes this need the
<h3>Why this should be an RC target</h3>
info & RC phase evaluation table? Also there's the "rc target triage" tag.I'd like this in for the 8.0 release for sure.
Comment #29
emma.mariaComment #30
galactus86 CreditAttribution: galactus86 commentedI'm in DrupalCon 2016 New Orleans, mentored sprints, going to review this.
Comment #31
galactus86 CreditAttribution: galactus86 commentedI'm in DrupalCon 2016 New Orleans, mentored sprints, going to review this.
Comment #32
galactus86 CreditAttribution: galactus86 commentedI took some text from #23 and added to the description. I also added that it is the default theme for Drupal 8. I did pair a programming with Unitoch and cdyksrtra.
Comment #33
cdykstra CreditAttribution: cdykstra commentedI did pair a programming with Unitoch and jasonPivot at DrupalCon NOLA 2016.
Comment #34
cdykstra CreditAttribution: cdykstra commentedComment #35
star-szrThe second sentence reads a bit awkwardly to me. Another suggestion:
Comment #36
lauriiiAccording to #35
Comment #37
mgiffordLooks like an easy fix.
Comment #38
gaurav.pahuja CreditAttribution: gaurav.pahuja as a volunteer and at Publicis Sapient commentedComment #40
snehi CreditAttribution: snehi as a volunteer and at Publicis Sapient for Publicis Sapient commented+1 for RTBC
Comment #41
pradeep22saini CreditAttribution: pradeep22saini commentedOn applying the patch #38 with git apply gives error. On drupal 8.2.x-dev branch.
Comment #42
pradeep22saini CreditAttribution: pradeep22saini commentedUpdated patch.
Comment #44
pradeep22saini CreditAttribution: pradeep22saini commentedComment #45
pradeep22saini CreditAttribution: pradeep22saini commentedComment #47
rajeshwari10 CreditAttribution: rajeshwari10 as a volunteer and at Blisstering Solutions commentedComment #48
rajeshwari10 CreditAttribution: rajeshwari10 as a volunteer and at Blisstering Solutions commentedThis issue is already fixed.
Comment #49
star-szr@rajeshwari10 thanks for looking into this. This issue hasn't been fixed yet so I'm reopening it. To give a couple tips: If it were fixed it would be helpful for you to point to an issue where this has been fixed, and in that case this would be closed as a duplicate issue (ideally with a reference made via the related issues field to/from the duplicate issue). Also the status of Closed (fixed) shouldn't be set by a human, that is only to be used by the system for issues that are set to 'Fixed' and have no activity after 2 weeks.
Comment #50
ashishdalviComment #51
ashishdalviUnable to apply patch. Tried patch reroll as well.
No reason why patch is failing. So uploading patch again.
Comment #52
ashishdalviComment #63
quietone CreditAttribution: quietone at PreviousNext commentedThanks everyone for contributing to this issue.
It has been quiet here for over 5 years and Olivero has been added and soon Claro. If the scope of this was changed to cover all themes then this can be fixed in one issue. And as a reviewer, it would a lot easier to review the changes to all the themes as once. This is similar to how the coding standard issues are done. With that in mind I have taken a bold step and updated the Issue Summary and Title.
Settings to NW for adding improvements to the text for all themes. Changing component to what I think is a better fit. Unassigning as well because it has been over 5 years.
Hope this helps get this moving again!