In InOperator Rename Views properties to core standards

New patch attached.

Updating issue tag. Will have a look at Drupal Camp Mumbai sprint on this weekend.

Still working on it.

The patch in 10 refers to pre-PSR directories (lib/Drupal/ instead of src/). I was going to reroll the patch per instructions in https://groups.drupal.org/node/424758, but the patch does not apply:

error: patch failed: core/modules/comment/lib/Drupal/comment/Plugin/views/filter/NodeComment.php:19
error: core/modules/comment/lib/Drupal/comment/Plugin/views/filter/NodeComment.php: patch does not apply
error: patch failed: core/modules/field/lib/Drupal/field/Plugin/views/filter/FieldList.php:20
error: core/modules/field/lib/Drupal/field/Plugin/views/filter/FieldList.php: patch does not apply
error: patch failed: core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/views/filter/TaxonomyIndexTid.php:358
error: core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/views/filter/TaxonomyIndexTid.php: patch does not apply
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/filter/InOperator.php:342
error: core/modules/views/lib/Drupal/views/Plugin/views/filter/InOperator.php: patch does not apply

What's the best course of action? Start over, or do a reroll from an earlier branch than 00339b3d?

10: drupal-rename_views_properties_inoperator-2183421-10.patch queued for re-testing.

I pulled the latest from 8.x, then switched to a commit that was four months, one day old. Sadly, it was the commit where chx was removed from maintainers.txt :(. In any event, the patch applied cleanly. A rebase with 8.x yielded four merge conflicts which I manually resolved. Then I followed the instructions that alimac linked to in comment #11. After running 'php core/scripts/switch-psr4.sh' one file was removed. I did a commit and a diff against 8.x. The rerolled patch from #10 is attached.

Thanks, @evilehk. I did the same thing (up to the merge conflicts). @Crisz indicated they were still working on it, so I wonder if some additional work will need to be done even if this passes the testbot tests.

We tried to apply the patch in 14 but there were a number of changes to the code base since it had been rolled and the patch failed to apply. So we recreated it, removing the references to the deleted file /core/modules/system/tests/Drupal/system/Tests/Menu/SystemLocalTasksTest.php and then fixed the updated InOperator file. This updated patch contains all the changes and successfully applied in our tests.

fixing the status so test bot can test the last submitted patch

Patch in #17 does not apply. Will work on a re-roll.

Here's the re-roll -- more work might be required.

Looks like a couple of references to `$form_state` in `core/modules/views/src/Plugin/views/filter/BooleanOperator.php` - fixing.

Re-rolled for latest HEAD.

1. +++ b/core/modules/views/src/Plugin/views/filter/Bundle.php
   @@ -48,7 +48,7 @@ public function init(ViewExecutable $view, DisplayPluginBase $display, array &$o
    
   

   I think this should be changed to valueTitle

2. +++ b/core/modules/views/src/Plugin/views/filter/LanguageFilter.php
   @@ -23,9 +23,9 @@ class LanguageFilter extends InOperator {
          $this->value_title = $this->t('Language');
   

   And this line too.

I think var $valueTitle = NULL; should be declared in class InOperator the way that $valueOptions is declared, but I'm not sure. This might be out of scope for this issue.

+++ b/core/modules/views/src/Plugin/views/filter/InOperator.php
@@ -80,8 +80,8 @@ public function defaultExposeOptions() {
-  public function buildExposeForm(&$form, FormStateInterface $form_state) {
-    parent::buildExposeForm($form, $form_state);
+  public function buildExposeForm(&$form, FormStateInterface $formState) {
+    parent::buildExposeForm($form, $formState);

just the properties are lowerCamelCase. The function vars use _.

----

gave it a quick look and that is all that stuck out for me.

True,

1. +++ b/core/modules/views/src/Plugin/views/filter/InOperator.php
   @@ -32,7 +32,7 @@ class InOperator extends FilterPluginBase {
   -  var $value_options = NULL;
   +  var $valueOptions = NULL;
   

   it should be protected $valueOptions, if possible.

2. +++ b/core/modules/views/src/Plugin/views/filter/InOperator.php
   @@ -199,21 +199,21 @@ protected function valueForm(&$form, FormStateInterface $form_state) {
   -          $default_value = array_shift($keys);
   +          $defaultValue = array_shift($keys);
   

   We don't use camelCase for local methods.

Restored underscores for local variables per #29, and added protected for $valueOptions and $valueTitle, per #30.

+++ b/core/modules/views/src/Plugin/views/filter/InOperator.php
@@ -32,7 +32,12 @@ class InOperator extends FilterPluginBase {
+  /**
+   * @var string
+   */
+  protected $valueTitle = NULL; ¶

we can add a short one line description. and get rid of the whitespace at the end of the line.

why NULL and not '' ? I'm not sure how to tell.

I removed the extra space mentioned in #32. Also removed 2 extra spaces that had been introduced at some point.

Since there wasn't a default value set before, changed protected $valueTitle = NULL; to just a declaration: protected $valueTitle;

+++ b/core/modules/views/src/Plugin/views/filter/InOperator.php
@@ -428,11 +435,11 @@ public function validate() {
-      $flat_options = form_options_flatten($this->value_options, TRUE);
+      $flatOptions = form_options_flatten($this->valueOptions, TRUE);

This variable should not have been changed from underscore to camelCase.

Restored variable name, and also removed an extra newline that crept in.

While working on this issue I noticed a typo in variable name in HandlerFilterPermissionTest.php ($permisssion_by_module) so I opened #2346215: In HandlerFilterPermissionTest fix typo in variable name, which is not related to this issue.

+++ b/core/modules/user/src/Tests/Views/HandlerFilterPermissionTest.php
@@ -78,7 +78,7 @@ public function testFilterPermission() {
-    $value_options = $view->filter['permission']->getValueOptions();
+    $valueOptions = $view->filter['permission']->getValueOptions();

@@ -90,7 +90,7 @@ public function testFilterPermission() {
-      $this->assertEqual($expected, $value_options[$title], 'Ensure the all permissions are available');
+      $this->assertEqual($expected, $valueOptions[$title], 'Ensure the all permissions are available');

Same thing :(

Restored local variable $value_options.

I have reviwed this issue applying the patch with --color-words and looking at every change on it. The variables valueTitle and valueOptions are always correct.
In some of this files I have detected little coding standars errors but involving the patch.

Committed 3bb1ac5 and pushed to 8.0.x. Thanks!