Sometimes in Firefox, whitespace will appear to the right of a sticky header, covering whatever else is there. In Chrome, the sticky headers sometimes don't line up with the correct columns.

Original report

On all browsers the sticky headers would place an "overlay" past the end of the page, not respecting the width and height properties assigned in the js file. Patch is provided to fix this issue.

CommentFileSizeAuthor
#4 core_2156335_sticky_headers.patch378 bytesliam morland
#3 core_2156335_sticky_headers.patch379 bytesliam morland
#1 After.png5.73 KBebremner
#1 Before.png12.23 KBebremner
tableheader-fixextendedheader.patch1.16 KBebremner

Comments

ebremner’s picture

ebremner commented
StatusFileSize
new Before.png12.23 KB
new After.png5.73 KB
ebremner’s picture

ebremner commented
Status: Patch (to be ported) » Needs review
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Title: Patch to fix sticky tables where header extend beyond pages on all browsers » Sticky headers sometimes display whitespace to the right or don't line up with table
Version: 7.23 » 7.x-dev
Issue summary: View changes
StatusFileSize
new core_2156335_sticky_headers.patch379 bytes

This patch does the same fix, but in the CSS file instead of in the JS.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
StatusFileSize
new core_2156335_sticky_headers.patch378 bytes

Fix typo.

Liam Morland queued 4: core_2156335_sticky_headers.patch for re-testing.

Liam Morland queued 4: core_2156335_sticky_headers.patch for re-testing.

kpaxman’s picture

kpaxman commented
Status: Needs review » Reviewed & tested by the community

This is happening on our sites when the theme sets the table to "min-width: 100%" (because, for our purposes, we want all tables to fill the content area); if we remove the min-width from our CSS, the sticky headers work as intended. With this patch, we don't have to remove the min-width.

For now, we'll add the CSS from the patch to our theme.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: core_2156335_sticky_headers.patch, failed testing.

Status: Needs work » Needs review

Liam Morland queued 4: core_2156335_sticky_headers.patch for re-testing.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: core_2156335_sticky_headers.patch, failed testing.

Status: Needs work » Needs review

Liam Morland queued 4: core_2156335_sticky_headers.patch for re-testing.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: core_2156335_sticky_headers.patch, failed testing.

Status: Needs work » Needs review

David_Rothstein queued 4: core_2156335_sticky_headers.patch for re-testing.

David_Rothstein’s picture

David_Rothstein commented
Status: Needs review » Reviewed & tested by the community

Testbot fluke.

David_Rothstein’s picture

David_Rothstein commented
Version: 7.x-dev » 8.0.x-dev
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs backport to D7

Not sure we want to change the background color to transparent like that.... couldn't that have other side effects?

Also, has this been tested for Drupal 8 to see if the bug exists there? From the code, it looks like it might, so I'm moving this to Drupal 8 for now.

Finally, is it possible this is (partially) a duplicate of #2097081: Sticky headers are not calculating the column widths properly.?

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

If you are ajax replacing the table
have a look at this patch and explanation (example):
#1764912-38: Fix regressions and further improve tableheader.js

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev
quietone’s picture

quietone commented
Status: Needs work » Closed (cannot reproduce)
Issue tags: +Bug Smash Initiative

More information about this issue was asked for in #17, 7 years. No additional information has been supplied, therefor closing.

If you are experiencing this problem on a supported version of Drupal reopen the issue, by setting the status to 'Active', and provide complete steps to reproduce the issue (starting from "Install Drupal core").

Thanks!