Hi,

Do you have any plans for further development of the module for D8?

I'd like to help you with its development or implementation on Drupal 8 from scratch.

Thanks,

id.Alan

CommentFileSizeAuthor
#11 taxonomy_menu-drupal_8_port-2150525-11-do-not-test.patch28.14 KBserhii.ua
#10 taxonomy_menu-add_info_yml-2150525-10-do-not-test.patch721 bytesserhii.ua
#6 taxonomy_menu-drupal_8_port-2150525-6-do-not-test.patch15.91 KBserhii.ua
#2 taxonomy_menu-drupal-8-port_2150525_2.patch23.01 KBserhii.ua

Comments

dstol’s picture

dstol
Primary language English
commented

Nothing currently planned. If you have patches, I'll happily review and commit them.

serhii.ua’s picture

serhii.ua commented
Status: Active » Needs review
StatusFileSize
new taxonomy_menu-drupal-8-port_2150525_2.patch23.01 KB

Here the first patch.
Our team (InternetDevels) continues working on porting module on Drupal 8.
So, I would like to be part of the story in future. Is there a chance for me to join the project as co-maintainers?

Status: Needs review » Needs work

The last submitted patch, 2: taxonomy_menu-drupal-8-port_2150525_2.patch, failed testing.

bohart’s picture

bohart
Location Lutsk, Ukraine
commented
Issue tags: +Needs reroll

Patch could not apply.
We need to re-roll it (and check this issue "Version").

Also seems that current tests does not compatible with D8.
I think we need to remove them and rewrite in future.

dstol’s picture

dstol
Primary language English
commented

Test failure here isn't a big deal. Considering that it's running against the 7.x-2.x branch, everything is likely to fail.

serhii.ua’s picture

serhii.ua commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new taxonomy_menu-drupal_8_port-2150525-6-do-not-test.patch15.91 KB

This is the correct patch.

Please create a new branch for D8 and commit changes.

dstol’s picture

dstol
Primary language English
commented
Version: 7.x-2.x-dev » 8.x-1.x-dev
Status: Needs review » Fixed

Created a branch and committed to 8.x! Exciting!

https://drupal.org/node/2177399

mgifford’s picture

mgifford
he/him
Primary language English
commented

This is amazing. Great to see this happen so quickly!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

serhii.ua’s picture

serhii.ua commented
Status: Closed (fixed) » Needs review
StatusFileSize
new taxonomy_menu-add_info_yml-2150525-10-do-not-test.patch721 bytes

In previous patch is missing info.yml file. This patch fix it.

Also exhibited correct permissions for the module files, that have changed.

serhii.ua’s picture

serhii.ua commented
StatusFileSize
new taxonomy_menu-drupal_8_port-2150525-11-do-not-test.patch28.14 KB

Please ignore comment #10,

I created a new patch for the module. This patch allows to use the basic functionality of the module. For other improvements will be created new issues.

My team and I will continue to work for the module.

Is there a chance for me to join the project as co-maintainers? I want to be closer to the project for its improvement.

dstol’s picture

dstol
Primary language English
commented

I've added you to the maintainers list. Feel free to go nuts with the D8 version.

serhii.ua’s picture

serhii.ua commented
Status: Needs review » Fixed

@dstol, Thanks.

Committed to 8.x 8ab0812.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.