Details: see #1991684: Node history markers (comment & node "new" indicator, "x new comments" links) forces render caching to be per user, particularly the issue summary and comment 40.

This issue was split off from that issue because the render cache breakage of the Forum module does not break entity render caching, which is what we were trying to unblock there.

Comments

Wim Leers’s picture

Title: Node history markers on Forum ("new" and "updated" markers, "x new posts" links) forces render caching to be per user » Forum history markers ("new" and "updated" markers, "x new posts" links) forces render caching to be per user
Status: Active » Postponed
Wim Leers’s picture

colinafoley’s picture

Assigned: Unassigned » colinafoley
colinafoley’s picture

Assigned: colinafoley » Unassigned
colinafoley’s picture

I did some initial work on this and felt it was appropriate to add it as a patch. You can use it as a starting direction or leave it.

While investigating this issue I opened two other bug reports:
#2488886: Forum - "new replies" message is escaped
#2489374: Forum - status indicator does not respect forum status

I think more work needs to be done on Forum's rendering before proceeding with this issue.

Fabianx’s picture

There is no patch, however ...

Wim Leers’s picture

@colinafoley Any chance you could post the patch you had? :)

colinafoley’s picture

Sorry everyone! Here's the WIP patch. Most of this is based off of how Comment handles history markers.

Wim Leers’s picture

larowlan’s picture

Status: Active » Needs review
lauriii’s picture

Assigned: Unassigned » lauriii

I'm working on this

lauriii’s picture

Assigned: lauriii » Unassigned

Not working on this right now. Maybe later

larowlan’s picture

Status: Needs review » Needs work

More accurate status

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.