Updated: Comment #0

Problem/Motivation

#2058321: Move the 'place block' UI into the block listing is copying much of the CSS used for the Node add form

Proposed resolution

Abstract it so that we don't have duplicate CSS

Remaining tasks

Do that

User interface changes

N/A

API changes

N/A

#2056173: Regression: Two-column layout is broken by vertical toolbar
#2058321: Move the 'place block' UI into the block listing

CommentFileSizeAuthor
#26 2061863-block-layout.png566.04 KBnayana_mvr
#24 reusable-classes.png155.96 KBravi kant
#3 abstractedCssSelectors2061863.patch853 bytesdekisha

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

Essentially everything in
http://drupalcode.org/project/drupal.git/blob/refs/heads/8.x:/core/modul...

All of the entity-meta-* stuff here
http://drupalcode.org/project/drupal.git/blob/refs/heads/8.x:/core/theme...

All of the layout-region-* stuff here
http://drupalcode.org/project/drupal.git/blob/refs/heads/8.x:/core/theme...

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Issue tags: -Block UI overhaul

This is important, but not essential to the Blocks UI.

dekisha’s picture

dekisha commented
Assigned: Unassigned » dekisha
Issue summary: View changes
Status: Active » Needs work
StatusFileSize
new abstractedCssSelectors2061863.patch853 bytes

Partially fixed, selectors optimized

dexterns88’s picture

dexterns88 commented
Assigned: dekisha » Unassigned
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Related issues: +#2361921: Re-order the 'place/configure block' form so it's focused on the task at hand.
lewisnyman’s picture

lewisnyman
he/him
commented
Issue tags: +frontend, +CSS
Parent issue: » #1995272: [Meta] Refactor module CSS files inline with our CSS standards
lewisnyman’s picture

lewisnyman
he/him
commented
Related issues: +#2017257: Create generic layout classes

Now that we have #2017257: Create generic layout classes this should be really easy

alanburke’s picture

alanburke commented
Status: Needs work » Closed (duplicate)

So this is being handled over in #2471791: Improve the CSS layout framework for Drupal's admin interface
so closing this one

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

This was an actionable issue, that is a bikeshed of awfulness. Would have been nice to just move this out of node.module.css :(

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Closed (duplicate) » Active
star-szr’s picture

star-szr
he/him
Primary language English
commented

We can mess with the core CSS now to move things around just not with Stable and Classy at this point, at least in most cases.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

ravi kant’s picture

ravi kant commented
StatusFileSize
new reusable-classes.png155.96 KB

The two columns classes are reusable in Claro admin theme.
claro

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

nayana_mvr’s picture

nayana_mvr commented
StatusFileSize
new 2061863-block-layout.png566.04 KB

Can someone please confirm if this ticket is still relevant? I found another ticket https://www.drupal.org/project/drupal/issues/3396523 in which the file node.module.css will be removed since it is no longer used. This is the same file which is being updated in the last patch submitted here #3. Also, noticed that classes in Block layout UI are different from the one attached in last comment.

block-layout

nayana_mvr’s picture

nayana_mvr commented
Status: Active » Needs review

Moving to Needs Review for maintainers feedback.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs review » Closed (won't fix)

the block ui is going to be replaced by experience builder eventually and it's now trivial to make grid/columns with CSS.