The documentation for hook_modules_preinstall() implies that it should be called once per install cycle, but the way it is actually invoked, it gets invoked once per module being installed, with an array of only one module (the one being installed at the time).
This isn't necessarily wrong, it just doesn't need to happen so many times.
Move the hook invocation from within the install loop to outside.
TBD
N/A
N/A
| Comment | File | Size | Author |
|---|---|---|---|
| #16 | 2057647-nr-bot.txt | 1.45 KB | needs-review-queue-bot |
| #12 | 2057647.patch | 1.2 KB | catch |
| #9 | 2057647.patch | 4.3 KB | catch |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
compare
Comments
Comment #9
catchThis might be OK, but there's one caveat:
Say you have two modules that are incompatible, and you install them at the same time - if the hook runs before each install, then whichever module gets installed first gets to react to the second module being installed. If both of them are installed in the same request, neither hook will run.
Uploading a patch doing what the issue summary suggests, to see if we have test coverage for that case.
Comment #10
catchComment #12
catchPatch without the cruft from another patch..
Comment #16
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.