Write tour integration for shortcuts page

Tour needs tests since we now have #2028535

Tagging for tracking.

Added shortcut patch

Changed the text a little, got the tour items working. Still needs tests though.

This needs to be re-rolled to use routes now #1918768: Refactor tour module to use routes instead of paths is in.

Tackling this during the Belgian DUG sprint.

Assigning to myself as issue has been inactive for two weeks.

New patch that updates shortcut Tour to use route instead of paths and adds additional tips to the shortcut Tour.

10: tour.shortcut-10.patch queued for re-testing.

I applied the patch and had to reinstall the tour module (as you do).

Manually tested and looks good. The tour worked on the shortcut page.

I got the patch to apply.

The tour ran fine, after reinstalling the tour module just like aczietlow said above.

I have one concern though, to a new Drupal user the last tour item that points to removing a link would probably seem to point to a space that does nothing. To people who have been around a while it make sense to click the drop down arrow first but it might confuse new people.

I think that most internet users are fairly familiar with drop downs/expansion by now. Given the pervasiveness of select lists and expanding menus in mobile responsiveness, I think it should be fairly intuitive. Anyone else have thoughts on this?

Attaching an screenshot that better captures the point made in #15

The issue is with step #5 in the tour. I think it would make sense to not have it overlap the drop down menu.

Ahh! I see. Agreed, I'll see about adjusting that and get a new patch in for testing.

Essentially, the target in question is too small to be accurately targeted by the arrow. Joyride aligns itself in relationship to the element, and then positions the nub about 25 pixels off of the corner in question. In practice, if you use "bottom" for the location (this is the default), Joyride will place the tip below the item, with the left edge of the tip aligned to the left edge of the element. The nub will then be approximately 25px from the top left corner, but the element in question is only about half that size, so the arrow appears to point to empty space. This is the behavior observed by rmorgan and aczietlow, but there isn't a position argument that adequately causes the arrow to point to the element. Drupal doesn't support the nubPosition argument that Joyride does, but even adding this argument wouldn't be sufficient to solve the problem of very small elements due to the limitations in the Joyride library.

With this in mind, I added some extra text to tip four indicating that the dropdown arrow was also responsible for deletions, and removed tip five. This patch is attached. Thoughts?

EDIT: For greater clarity and great justice!! (Or maybe just the clarity.)

Uploaded working patch.

Marking for testing

21: tour.shortcut-19.patch queued for re-testing.

For testing the patch, I applied the patch, uninstalled and reinstalled the shortcuts module, and rebuilt the cache. I then navigate to the shortcuts management page (admin/config/user-interface/shortcut/manage/default/customize)

I'm only seeing 2 of the 4 steps listed in the patch.

I can see all four tour tips. But I think the wording/copywritings needs some love — it feels very rough. It doesn't have to be perfect though.

This also needs test coverage, see #1 and ViewsUITourTest.

This one seems like a good thing to do, but postponed on #1921152-109: META: Start providing tour tips for other core modules. for now.

Working on this issue from mentored core sprint @ Nashville DrupalCon.

Patch for the first shortcuts management page. I'd think that subsequent pages are mostly common UI, so probably won't need tour elements.

uuid needs to be removed. please add another patch. Thanks

Ha ha, you're correct. This should be better.

Remove hyphenated word in the shortcut general, I guess. Thanks

Updated patch:

1. Moved from config/install to config/optional
2. Made the tour a bit more accurate... after a quick refresher on shortcuts

Fixed failed tests and added a test for the Shortcut Tour tips.

Fixing failed tests.

Hi
I have made some changes to the patch #52. Replaced id and class with proper data-class.
Also I have removed the tip pointing to the main navigation menu because that is not the part of the Shortcuts page and it fails the tests as the corresponding element doesn't gets found on the shortcuts page.
Also added a tour tip to the "Add shortcuts" Link.

Thank you @ridhimaabrol24 for working on the patch.

+++ b/core/modules/shortcut/tests/src/Functional/ShortcutTourTest.php
@@ -0,0 +1,51 @@
+  public static $modules = ['block', 'shortcut', 'tour'];

This property should be protected now.

Thank you for the feedback @jibran. Made the changes.

Accommodate later changes in tour configuration files. Simple diff provided, interdiff failed due changes in base code. Re-rolled.

Fixes configuration entries order.

So this is now postponed as shortcut is going to be removed #3311180: [meta] Determine how to make Shortcut module more useful and maintainable

Also tour is update for consideration #3325445: [Policy] Remove tour module from core

But positive news if tour moves out it has less gates to go through in contrib.

The decision to remove Shortcut has not been made yet. But Tour has been removed from core, so this no longer something to fix in core.

I'll move it Tour.

Integrated tour for shortcut module & added test coverage, attached the screenshots.

Please review, moving NR