LDAP Server: Improve checking server status before performing LDAP requests [#2043539]

There are various places where the server configuration status (enabled/disabled) is not checked before performing LDAP server requests. Adding checks for server status would allow for a more flexible system that can be toggled on and off as needed. For instance: developer environment - server config disabled, production environment - server config enabled.

Comment	File	Size	Author
#4	ldap-check-server-status-2043539-4.patch	5.05 KB	recrit
#4	7.x-2.x: PHP 5.4 & MySQL 5.5, D7 21 pass PHP 5.5 & MySQL 5.5, D7 21 pass PHP 5.6 & MySQL 5.5, D7 21 pass
#1	ldap-check-server-status-2043539-1.patch	5 KB	recrit
#1	7.x-2.x: PHP 5.4 & MySQL 5.5, D7 21 pass, 1 fail PHP 5.5 & MySQL 5.5, D7 21 pass, 1 fail PHP 5.6 & MySQL 5.5, D7 21 pass, 1 fail

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

recrit CreditAttribution: recrit commented 16 July 2013 at 21:29

File	Size
ldap-check-server-status-2043539-1.patch	5 KB
7.x-2.x: PHP 5.4 & MySQL 5.5, D7 21 pass, 1 fail PHP 5.5 & MySQL 5.5, D7 21 pass, 1 fail PHP 5.6 & MySQL 5.5, D7 21 pass, 1 fail

the patch attached adds server config status checks in the majority of places where server requests would be made. This most likely does not capture all of them.

Comment #2

recrit CreditAttribution: recrit commented 16 July 2013 at 21:30

Status:

Active

» Needs review

Comment #3

johnbarclay CreditAttribution: johnbarclay commented 18 July 2013 at 03:44

Title:

Improve checking server status before performing LDAP requests

» LDAP Server: Improve checking server status before performing LDAP requests

Thanks. We should just leave this issue open until there is more coverage. I'll commit these as they come along. A search for calls to the get server functions should locate them all.

Comment #4

recrit CreditAttribution: recrit commented 15 April 2014 at 12:41

Issue summary:

View changes

File	Size
ldap-check-server-status-2043539-4.patch	5.05 KB
7.x-2.x: PHP 5.4 & MySQL 5.5, D7 21 pass PHP 5.5 & MySQL 5.5, D7 21 pass PHP 5.6 & MySQL 5.5, D7 21 pass

updated patch for latest 7x.-2.x-dev

Comment #5

grahl

he/him

Zürich

CreditAttribution: grahl as a volunteer commented 11 February 2017 at 18:54

Status:

Needs review

» Needs work

Comment #6

grahl

he/him

Zürich

CreditAttribution: grahl as a volunteer commented 11 February 2017 at 18:54

Status:

Needs work

» Needs review

Zürich

CreditAttribution: grahl as a volunteer commented 18 March 2017 at 16:23

Can someone confirm, that this works with our regressions? Ideally in multiple environments?

Comment #11

grahl

he/him

Zürich

CreditAttribution: grahl as a volunteer commented 19 November 2017 at 16:00

Status:	Needs review	» Closed (won't fix)
Related issues:		+#2459589: LDAP Authentication: provide an enabled variable (TRUE / FALSE)

We don't need this in 8 due to the configuration system in general for multiple environments and workarounds for 7 have been provided in the related issue. Therefore I'm closing this issue.