After adding a dataset through the ajax form "Show" shows up on the resource form. Remove it. Image in comments.

CommentFileSizeAuthor
#19 field-group-show-ajax-2042681-18-D7.patch693 bytesmarkabur
#17 IEF-fieldgroups.png174.54 KBmrpauldriver
#9 field-group-show-ajax-2042681-8.patch987 bytesgrasmash
#8 recline-embed-1810098-13.patch7.08 KBgrasmash
#7 field-group-show-ajax-2042681-6.patch682 bytesacouch
#2 dkan-link-to-file-ajax-2042681-7734141.patch1.79 KBchilic
#4 dkan-link-to-file-ajax-2042681-7734141.patch850 byteschilic
#3 Screen Shot 2013-08-11 at 3.18.01 PM.png47.09 KBacouch
#3 Screen Shot 2013-08-11 at 3.18.16 PM.png38.92 KBacouch
#1 show_on_ajax.jpg136.75 KBacouch

Comments

acouch’s picture

acouch commented
StatusFileSize
new show_on_ajax.jpg136.75 KB

See:
ajax form

chilic’s picture

chilic commented
Component: DKAN Dataset » Documentation
Status: Needs work » Active
StatusFileSize
new dkan-link-to-file-ajax-2042681-7734141.patch1.79 KB

Please try attached patch.

UPD: this patch wrong. See https://drupal.org/node/2042681#comment-7746567

acouch’s picture

acouch commented
Component: Code » DKAN Dataset
Assigned: Unassigned » chilic
Status: Active » Needs work
StatusFileSize
new desired38.92 KB
new afterpatch47.09 KB

I'm not sure if the instructions were unclear, but the desired result is to remove "Show" from all of the tabs at the top of the form.

When I tried this patch, it completely removed "Upload a File":

afterpatch

What I want is for it to look like this, even on the ajax form:

desired

chilic’s picture

chilic commented
StatusFileSize
new dkan-link-to-file-ajax-2042681-7734141.patch850 bytes

Sorry first patch is wrong.
Please try this patch.

acouch’s picture

acouch commented
Component: Documentation » DKAN Dataset
Status: Active » Needs work

Great! I can confirm this works. I added this patch to DKAN Dataset: http://drupalcode.org/project/dkan_dataset.git/commit/0a5388f

This should be applied to field_group module. Moving there.

acouch’s picture

acouch commented
Title: forms. "Show Link to a File" with Ajax. » "Show" appears in horizontal tab title if node form submitted through ajax
Project: DKAN » Field Group
Version: » 7.x-1.x-dev
Component: DKAN Dataset » User interface
Assigned: chilic » Unassigned
Status: Needs work » Needs review

The "Show" added by Drupal core: http://drupalcode.org/project/drupal.git/blob/refs/heads/7.x:/misc/colla... is added to the tab title if the form is delivered by ajax. The patch in #4 fixes that by first removing the '.invisible elements' span. This was initially identified in the DKAN distro hence the earlier comments.

acouch’s picture

acouch commented
StatusFileSize
new field-group-show-ajax-2042681-6.patch682 bytes

Updating for field_group as opposed to dkan.

acouch’s picture

acouch commented
Issue summary: View changes

Updated issue summary.

grasmash’s picture

grasmash commented
Issue summary: View changes
StatusFileSize
new recline-embed-1810098-13.patch7.08 KB

Ignore this, incorrect attachment.

grasmash’s picture

grasmash commented
StatusFileSize
new field-group-show-ajax-2042681-8.patch987 bytes

Rerolling against 7.x-1.3

The last submitted patch, 8: recline-embed-1810098-13.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 9: field-group-show-ajax-2042681-8.patch, failed testing.

Status: Needs work » Needs review

chilic queued 9: field-group-show-ajax-2042681-8.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 9: field-group-show-ajax-2042681-8.patch, failed testing.

The last submitted patch, 4: dkan-link-to-file-ajax-2042681-7734141.patch, failed testing.

The last submitted patch, 2: dkan-link-to-file-ajax-2042681-7734141.patch, failed testing.

The last submitted patch, 7: field-group-show-ajax-2042681-6.patch, failed testing.

mrpauldriver’s picture

mrpauldriver commented
StatusFileSize
new IEF-fieldgroups.png174.54 KB

I am finding something very similar with inline entity forms (commerce kickstart)

Please see screenshot

Anonymous’s picture

Anonymous (not verified) commented

The concept of this patch is correct. I've manually edited horizontal-tabs.js, and "Show" is no longer displayed in the horizontal tab label. Just need clean up on the format of the patch.

markabur’s picture

markabur commented
Status: Needs work » Needs review
StatusFileSize
new field-group-show-ajax-2042681-18-D7.patch693 bytes

Patch rerolled for the latest dev.

mmenavas’s picture

mmenavas commented

I have reviewed patch #19, and it works as expected. What do we need to do to get this patch incorporated in the latest dev version?

sebi’s picture

sebi commented

I can confirm #19 also works

stevesmename’s picture

stevesmename commented
stevesmename’s picture

stevesmename commented
Status: Needs review » Reviewed & tested by the community
aubjr_drupal’s picture

aubjr_drupal commented

To the maintainer - Please add this commit to the module.

  • zuuperman committed 40c1a73 on 7.x-1.x authored by markabur 
    Issue #2042681 by chilic, grasmash, acouch, markabur, MrPaulDriver: "...
nils.destoop’s picture

nils.destoop commented
Status: Reviewed & tested by the community » Fixed

Committed to dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.