Exceptions when locking tempstore try to use collection protected property while I guess they should use getCollectionName() instead

CommentFileSizeAuthor
#13 2031599_13.patch2.07 KBKetan Harit
#11 2031599-11.patch1.99 KBtadityar
#9 2031599-9.patch1.99 KBtadityar
#7 2031599-6.patch3.07 KBjain_deepak
#5 2031599-5.patch3.26 KBjain_deepak
#3 2031599-3.patch3.79 KBdawehner
#1 2031599-tempstore-collection.patch1.05 KBpcambra

Comments

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Status: Active » Needs review
StatusFileSize
new 2031599-tempstore-collection.patch1.05 KB
dawehner’s picture

dawehner
Primary language German
commented
Issue tags: +PHPUnit

Let's introduce some unit tests as well.

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new 2031599-3.patch3.79 KB

This time with the actual patch.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Issue summary: View changes
Status: Needs review » Needs work
Issue tags: +Needs reroll

It looks like there are now some unit tests for TempStore. This needs a reroll too.

jain_deepak’s picture

jain_deepak commented
Status: Needs work » Needs review
StatusFileSize
new 2031599-5.patch3.26 KB

Rerolled

Status: Needs review » Needs work

The last submitted patch, 5: 2031599-5.patch, failed testing.

jain_deepak’s picture

jain_deepak commented
Status: Needs work » Needs review
StatusFileSize
new 2031599-6.patch3.07 KB

Rerolled

Status: Needs review » Needs work

The last submitted patch, 7: 2031599-6.patch, failed testing.

tadityar’s picture

tadityar commented
Status: Needs work » Needs review
StatusFileSize
new 2031599-9.patch1.99 KB

Trying to re-roll.

Status: Needs review » Needs work

The last submitted patch, 9: 2031599-9.patch, failed testing.

tadityar’s picture

tadityar commented
Status: Needs work » Needs review
StatusFileSize
new 2031599-11.patch1.99 KB

Typo-ed

Status: Needs review » Needs work

The last submitted patch, 11: 2031599-11.patch, failed testing.

Ketan Harit’s picture

Ketan Harit commented
Status: Needs work » Needs review
Issue tags: -Needs reroll +sprintweekendDelhi
StatusFileSize
new 2031599_13.patch2.07 KB

Status: Needs review » Needs work

The last submitted patch, 13: 2031599_13.patch, failed testing.

yesct’s picture

yesct commented
Issue tags: -sprintweekendDelhi +SprintWeekend2015

Thank you for opening this issue.

We should all try and use the same sprint tag. According to https://groups.drupal.org/node/447258 it should be SprintWeekend2015 with no #.

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Title: Replace collection by getCollectionName() in Tempstore » Add lock set/delete tempstore tests
Issue tags: -SprintWeekend2015

Loads have changed since this was opened, the actual fix was done in #2008806: Add getIfOwner(), setIfOwner() and deleteIfOwner() methods to TempStore., so I think only the tests need to be added, but TempStore has been split into \Drupal\user\SharedTempStore and \Drupal\user\PrivateTempStore (#2421263: Potential data loss: concurrent (i.e. by different users) node edits leak through preview), do we need to add those to both?

mgifford’s picture

mgifford
he/him
Primary language English
commented
Assigned: pcambra » Unassigned

Unassigning stale issue. Hopefully someone else will pursue this.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Needs work » Postponed (maintainer needs more info)
Issue tags: +stale-issue-cleanup

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

smustgrave’s picture

smustgrave commented
Status: Postponed (maintainer needs more info) » Closed (outdated)

Think this one can be closed out, the tests were refactored in SharedTempStoreTest which seems to cover the scenariosl

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.