Files: 
CommentFileSizeAuthor
#17 views-rename_op_not_starts-2003538-17.patch1.76 KBJeroenT
PASSED: [[SimpleTest]]: [MySQL] 55,952 pass(es).
[ View ]
#14 drupal_rename_op_not_starts-2003538-14.patch1.75 KBnathangervais
PASSED: [[SimpleTest]]: [MySQL] 55,615 pass(es).
[ View ]
#10 views-rename_op_not_starts-2003538-10.patch1.76 KBJeroenT
PASSED: [[SimpleTest]]: [MySQL] 56,828 pass(es).
[ View ]
#5 views.module-rename-op_not_starts-2003538-05.patch1.74 KBtoddtomlinson
FAILED: [[SimpleTest]]: [MySQL] 55,854 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Comments

toddtomlinson’s picture

Assigned:Unassigned» toddtomlinson
Elijah Lynn’s picture

I am going to give this a go right now at the DrupalCon Sprint!

Elijah Lynn’s picture

Assigned:Elijah Lynn» Unassigned

Sorry Todd, we both did that at the same time coincidentally.

toddtomlinson’s picture

Ha! What are the odds?

toddtomlinson’s picture

Status:Active» Needs review
StatusFileSize
new1.74 KB
FAILED: [[SimpleTest]]: [MySQL] 55,854 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

patch attached that renames op_not_starts with addNotStartsWith

Elijah Lynn’s picture

Status:Needs review» Reviewed & tested by the community

Yeah, small world!

Applies cleanly and no errors with mild testing.

Status:Reviewed & tested by the community» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, views.module-rename-op_not_starts-2003538-05.patch, failed testing.

alexweber’s picture

Status:Needs work» Needs review

Status:Needs review» Needs work
Issue tags:+Novice, +VDC

The last submitted patch, views.module-rename-op_not_starts-2003538-05.patch, failed testing.

JeroenT’s picture

StatusFileSize
new1.76 KB
PASSED: [[SimpleTest]]: [MySQL] 56,828 pass(es).
[ View ]

rename op_not_starts to addNotStartsWith.

JeroenT’s picture

Status:Needs work» Needs review

marking as needs review.

heddn’s picture

Status:Needs review» Reviewed & tested by the community

No mentions of op_not_starts and applies cleanly. Passed testbot.

alexpott’s picture

Status:Reviewed & tested by the community» Needs work

In #2003582: Rename Views method op_equal() to opEqual() it was decided to not rename a function from op_whatever to addWhatever. So to be consistent this patch should just change the name to opNotStartsWith - I'm okay with adding the with as this is what it does.

nathangervais’s picture

Status:Needs work» Needs review
StatusFileSize
new1.75 KB
PASSED: [[SimpleTest]]: [MySQL] 55,615 pass(es).
[ View ]

Rerolled patch to rename op_not_starts() to opNotStartsWith

heddn’s picture

Title:Rename Views method op_not_starts() to addNotStartsWith()» Rename Views method op_not_starts() to opNotStartsWith()

Fixing title.

aspilicious’s picture

Status:Needs review» Needs work

Talkes with dawehner about this, should be protected. Srry!

JeroenT’s picture

StatusFileSize
new1.76 KB
PASSED: [[SimpleTest]]: [MySQL] 55,952 pass(es).
[ View ]

Changed access modifier to protected as mentioned by aspilicious.

JeroenT’s picture

Status:Needs work» Needs review

Marking as needs review.

dawehner’s picture

Status:Needs review» Reviewed & tested by the community

Patch still applies and looks fine.

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed c5d336e and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.