After #1804614: [meta] Consolidate similar twig templates and properly use theme suggestions in core lands, this issue should be changed to active.

We would like to eliminate theme_tablesort_indicator in favor of theme_image but we should add a theme hook succestion so that the table sort indicator can be easily overridden.

Issue fork drupal-1973418

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

lewisnyman’s picture

lewisnyman
he/him
commented

I'd like to expand the scope of this issue to discuss whether we need the table sort indicator to be an inline image. It's clearly presentational.

thedavidmeister’s picture

thedavidmeister commented

alternative potentially being something like remove the img tag completely + add the up/down arrow icon back in with CSS on the table header by doing something in tablesort_header() and add back in an equivalent solution for the title/alt tags explaining the sort behaviour that are currently on the image for accessibility reasons, also in tablesort_header().

jenlampton’s picture

jenlampton
she / her
commented
Issue tags: +Twig, +Template consolidation

tagging

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

@LewisNyman and @thedavidmeister one counter reason to that would be CSS images don't like to to load in parallel, AFAIK so it would be a bit slower, and also someone would likely like to replace those images with maybe an icon webfont or svg?

Though if we were to go in the CSS direction I'd hope for maybe spriteing some of these?

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

I'm +1 for getting this in CSS:)

star-szr’s picture

star-szr
he/him
Primary language English
commented
Issue summary: View changes
Related issues: +#2189729: Factor out tablesort-indicator.html.twig
mgifford’s picture

mgifford
he/him
Primary language English
commented
Status: Postponed » Active

What is this postponed on? At this stage it should be bumped up to 8.1.0 or addressed shouldn't it?

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Issue tags: +CSS, +frontend

Good question, maybe just that all consolidation was postponed...

Tagging with CSS as I hope for that solution:)

lewisnyman’s picture

lewisnyman
he/him
commented
Title: Remove theme_tablesort_indicator, use theme_image instead, with appropriate theme hook suggestion » Remove theme_tablesort_indicator, use CSS instead
mitokens’s picture

mitokens commented
Parent issue: » #1804614: [meta] Consolidate similar twig templates and properly use theme suggestions in core
sqndr’s picture

sqndr commented
Assigned: Unassigned » sqndr

I will look into this issue this week.

sqndr’s picture

sqndr commented
Status: Active » Fixed

The theme() function has already been removed.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Title: Remove theme_tablesort_indicator, use CSS instead » Remove tablesort-indicator.html.twig, use CSS instead
Assigned: sqndr » Unassigned
Status: Fixed » Active

I think we still want to remove it even though it's a Twig template now :)

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Oh yes, thanks! Yeah this doesn't need to be a template and even if it was a twig template I'd be tempted to put it in the table.html.twig to avoid the performance hit.

CSS approach would be simpler though.

lokapujya’s picture

lokapujya
Primary language English
Location Boston
commented

interesting question: use a template or remove it? wondering what the reason is for removing it.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Issue tags: +Needs issue summary update

Because it's a tiny template, and CSS is a thing.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Version: 8.0.x-dev » 8.1.x-dev

Bumping to D8.1

andypost’s picture

andypost
he/him
Primary language Russian
commented
Version: 8.1.x-dev » 9.x-dev
Status: Active » Postponed

Stable theme has this template so probably this becomes 9.x

catch’s picture

catch
he/him
Primary language English
commented
Version: 9.x-dev » 8.2.x-dev
Status: Postponed » Active

No we can stop using the template in core in a minor release, just can't completely remove it.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Active » Postponed (maintainer needs more info)
Issue tags: +stale-issue-cleanup

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

catch’s picture

catch
he/him
Primary language English
commented
Status: Postponed (maintainer needs more info) » Active
Related issues: +#3533198: [Meta] Make Drupal the first "design-system native" CMS + Unify & simplify render & theme systems

This is still valid one way or another. The template shouldn't exist as it currently is.

sanket.tale made their first commit to this issue’s fork.

sanket.tale opened merge request !13191

sanket.tale’s picture

sanket.tale commented

Pipeline is failing on AjaxWaitTest::testUntrackedXhr. I already restored the tablesort-indicator.html.twig file as empty, but this test is still failing. It looks unrelated to my change. Please guide me on how to proceed with this pipeline failure.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.