When checking "mark required fields" for a tab the "*" doesn't get displayed on the tab.

CommentFileSizeAuthor
#1 1957596.0.patch3.92 KBcha0s

Comments

cha0s’s picture

cha0s commented
Assigned: Unassigned » cha0s
Status: Active » Needs work
StatusFileSize
new 1957596.0.patch3.92 KB

Patch attached, still needs error handling (focusing tabs that contain an element with an error for instance), but this is better than nothing for now.

cha0s’s picture

cha0s commented
Title: Required field marking isn't displayed » Fields need proper error handling behavior in JS
cha0s’s picture

cha0s commented
Issue summary: View changes

spelling/gramar

playfulwolf’s picture

playfulwolf commented
Issue summary: View changes

Is this committed?

Argus’s picture

Argus commented

Nope, the status is "needs work". You could try to apply the patch for now.

playfulwolf’s picture

playfulwolf commented

Can confirm this works without issues for "required" but not for "error" states (tabs are not highlighted when submitting without filling required fields in them). Can we mark this RTBC?

  • Commit 85c60ca on master by cha0s: 
    Issue #1957596 by cha0s: Handle required fields

  • Commit 85c60ca on master, 7.x-1.x by cha0s: 
    Issue #1957596 by cha0s: Handle required fields
cha0s’s picture

cha0s commented

I committed the patch I had. Let's keep this issue open for the error handling behavior.