Follow-up for #1658846-187: Add language support to node access grants and records

Problem/Motivation

Original node access issue had inline comments using third person verb tense.

Proposed resolution

(Don't change the tense of verbs on functions, those should be third person: Tests...)

Change inside functions the inline comments to be Test ... or Verify that..

Remaining tasks

  • Find in the standard if it really should be Test .. (check 1354). Link to it and quote the section in the motivation part of the issue summary.
  • Decide if this should fix just those introduced in the original issue, or if this should fix more in other places in core.
  • Implement resolution. See contributor task document for creating a patch: http://drupal.org/node/1424598

User interface changes

No UI changes.

API changes

No API changes.

Original report by @xjm

In #1658846-187: Add language support to node access grants and records

+++ b/core/modules/node/lib/Drupal/node/Tests/NodeAccessLanguageTest.phpundefined
@@ -61,31 +47,196 @@ function testNodeAccess() {
+    // Tests that access is not granted if requested with no language.
...
+    // Tests that access is not granted if requested with Hungarian language.
...
+    // Tests that access is not granted if requested with no language.
...
+    // Tests that Hungarian is still not accessible.
...
+    // Tests that Catalan is still not accessible.

These can all be "Test" or "Verify" or something rather than "Tests". (Ditto for similar comments elsewhere.)

Comments

Gábor Hojtsy’s picture

Do we have standard suggestions for this or is this is an "it feels better"?