Follow-up for #1658846-187: Add language support to node access grants and records

Problem/Motivation

Original node access issue had inline comments using third person verb tense.

Proposed resolution

(Don't change the tense of verbs on functions, those should be third person: Tests...)

Change inside functions the inline comments to be Test ... or Verify that..

Remaining tasks

  • Find in the standard if it really should be Test .. (check 1354). Link to it and quote the section in the motivation part of the issue summary.
  • Decide if this should fix just those introduced in the original issue, or if this should fix more in other places in core.
  • Implement resolution. See contributor task document for creating a patch: http://drupal.org/node/1424598

User interface changes

No UI changes.

API changes

No API changes.

Original report by @xjm

In #1658846-187: Add language support to node access grants and records

+++ b/core/modules/node/lib/Drupal/node/Tests/NodeAccessLanguageTest.phpundefined
@@ -61,31 +47,196 @@ function testNodeAccess() {
+    // Tests that access is not granted if requested with no language.
...
+    // Tests that access is not granted if requested with Hungarian language.
...
+    // Tests that access is not granted if requested with no language.
...
+    // Tests that Hungarian is still not accessible.
...
+    // Tests that Catalan is still not accessible.

These can all be "Test" or "Verify" or something rather than "Tests". (Ditto for similar comments elsewhere.)

Files: 
CommentFileSizeAuthor
#3 modification_in_grammar-10233741-3.patch9.94 KBjoyceg
PASSED: [[SimpleTest]]: [PHP 5.5 MySQL] 104,178 pass(es). View

Comments

Gábor Hojtsy’s picture

Do we have standard suggestions for this or is this is an "it feels better"?

joyceg’s picture

Assigned: Unassigned » joyceg

I am working on this issue.

joyceg’s picture

FileSize
9.94 KB
PASSED: [[SimpleTest]]: [PHP 5.5 MySQL] 104,178 pass(es). View

Adding the patch here.

joyceg’s picture

Status: Active » Needs review
YesCT’s picture

Status: Needs review » Postponed
Parent issue: » #2571965: [meta] Fix coding standards in core

we should not go through with this, until at least the remaining task that says "find the standard and link to it" is done.

but even more, we have a new strategy for dealing with coding style only changes: #2571965: [meta] Fix coding standards in core

postponing this until:
we have a sniffer running automatically, and we can add a rule that checks this particular standard.

for more background, see #1518116-86: [meta] Make Core pass Coder Review

I would also recommend working on bugs (that do not require api changes). tasks can be tricky to know if they are allowed to be committed depending on the phase of the release we are in.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.