Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
I've added a variable for the date range separater so it can be easily swapped out in another module or theme, without someone have to duplicate the entire function.
This is only a small change, but would allow for more flexibility in the futre...
Comment | File | Size | Author |
---|---|---|---|
#7 | 1925774-7-sandykadam-fix-for-date-range-separator--do-not-test.patch | 1.33 KB | sandykadam |
date-added_variable_range_separator.patch | 787 bytes | Anonymous (not verified) | |
Comments
Comment #1
Anonymous (not verified) CreditAttribution: Anonymous commentedBump...
Comment #1.0
Anonymous (not verified) CreditAttribution: Anonymous commentedAdded details.
Comment #2
podarokall feature requests should be covered by tests
secondary issue - You should use hook_uninstall for deleting variable, introduced here
Comment #3
sandykadam CreditAttribution: sandykadam commented@kye There is no need of adding separate variable, we can manage by theme variables. I have attached patch for same.
Comment #5
sandykadam CreditAttribution: sandykadam commentedSorry ignore previous patch, uploaded incorrect file. Check attached updated patch.
Comment #7
sandykadam CreditAttribution: sandykadam commentedThere is no test required for this so renaming the patch and resubmitting the patch.
Comment #8
andriyun CreditAttribution: andriyun as a volunteer commentedComment #9
andriyun CreditAttribution: andriyun as a volunteer commentedComment #10
Chris Matthews CreditAttribution: Chris Matthews as a volunteer commentedThe 5 year old patch in #7 to date.module and date.theme does not apply to the latest 7.x-2.x-dev may be too old to reroll, but I went ahead and tagged the issue accordingly.