Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
At #1874664: Introduce toolbar level "Edit" mode that shows all contextual links, "Edit mode" was moved from edit.module to contextual.module. Instead of being about in-place editing, it's now about showing all contextual links triggers (which were nigh impossible to use on touch devices previously, and thus still are in Drupal 7).
Contextual links triggers now are pencil icons instead of gear icons.
The "edit/show pencils mode" Toolbar tab toggle is the same pencil icon. By default, it's off (i.e. no contextual links triggers are displayed on the page), but it's possible to toggle it on, in which case it will get a blue, gradient background. This can be considered a "special style", and the question is whether this should be made into a pattern, or should remain a one-off.
Proposed resolution
Discuss to figure out whether this should be made into a pattern or not.
Remaining tasks
TBD.
User interface changes
None.
API changes
None.
Comments
Comment #1
Wim Leers.
Comment #2
catchWhat't this postponed on?
Comment #3
yoroy CreditAttribution: yoroy commentedIncomprehensible issue title :-)
Why is this major?
Comment #4
Wim LeersThe issue summary contains the full explanation.
I think this was postponed on #1874664: Introduce toolbar level "Edit" mode that shows all contextual links because that issue had not yet been committed. I think we'll revisit this in the days to come.
Comment #5
webchickReducing to normal since no one else can seem to figure out why it is major, including me. :)
Comment #6
Wim LeersWe're not fixing this in the current sprint.
I think this actually belongs in the
toolbar.modulecomponent, because it's about creating a pattern/standardized approach for the toolbar.Comment #8
tkoleary CreditAttribution: tkoleary at Acquia commentedNow that we are looking at moving this to the right, we need to re-asses this.
The blue styling was removed as part of another issue and IMO it needs to be put back *and* it does indeed need to be a one-off.
Toggling between viewing and editing the site is a unique pattern that should not be repeated, because to repeat it would diminish it's clarity and discoverability.
Comment #9
tkoleary CreditAttribution: tkoleary at Acquia commentedComment #10
Wim LeersSo this is then effectively blocked on #2732443: Finalize the behavior for triggering view/edit/build modes from the toolbar (and fix the "disappearing toolbar") AFAICT.
Comment #11
tkoleary CreditAttribution: tkoleary at Acquia commented@Wim Leers
Yes, that's right. But should be unblocked soon as that is being usability tested now.
Comment #18
nod_7 years later we can say it was a one-off thing :)
Comment #19
xjm