This is a sub-issue offocused on correctly adding @param and @return type hinting to the Comment module.
Documentation patches that include type hinting are time consuming to both review and commit because one must dig into the actual code to confirm that the type hints are both correct and complete. Hence, please be patient and try to limit type hint patches to covering only a limited number of docblocks (10-15 as a guess).
How To Review This Issue
- Attempt to apply the patch to see if it needs a reroll.
- Use the phpcs one-liner to evaluate whether all the relevant standards errors have been resolved: https://gist.github.com/paul-m/227822ac7723b0e90647
- Look at each change and determine whether the type hint is correct.
Related sprint issues:
|Sprint Topic||Sub Issue|
|Task||Novice task?||Contributor instructions||Complete?|
|Reroll the patch if it no longer applies.||Novice||Instructions||Done|
|Manually check type hints validity||Novice||Instructions|
PASSED: [[SimpleTest]]: [PHP 5.5 MySQL] 114,048 pass(es). View